Optimized recursive_bubble_sort by realDuYuanChao · Pull Request #2410 · TheAlgorithms/Python

realDuYuanChao · 2020-09-08T07:00:14Z

Describe your change:

Add an algorithm?
Fix a bug or typo in an existing algorithm?
Documentation change?

Checklist:

realDuYuanChao · 2020-09-08T07:07:22Z

@cclauss Please review. Thanks in advance :)

sorts/recursive_bubble_sort.py

realDuYuanChao

@cclauss fixed

sorts/recursive_bubble_sort.py

TravisBuddy · 2020-09-08T08:46:33Z

Hey @shellhub,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: cb2f0a90-f1af-11ea-ba41-b1d3a642fad8

TravisBuddy · 2020-09-08T08:47:29Z

Hey @shellhub,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: ec7590c0-f1af-11ea-ba41-b1d3a642fad8

TravisBuddy · 2020-09-08T08:48:43Z

Hey @shellhub,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: 18cf7a50-f1b0-11ea-ba41-b1d3a642fad8

TravisBuddy · 2020-09-08T08:49:43Z

Hey @shellhub,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: 3c4e1630-f1b0-11ea-ba41-b1d3a642fad8

cclauss · 2020-09-08T08:51:42Z

https://travis-ci.com/github/TheAlgorithms/Python/builds/183314106#L255

realDuYuanChao

fix build error

sorts/recursive_bubble_sort.py

TravisBuddy · 2020-09-08T09:06:36Z

Travis tests have failed

Hey @shellhub,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: 97257ab0-f1b2-11ea-ba41-b1d3a642fad8

realDuYuanChao · 2020-09-08T09:14:19Z

@cclauss why Travic CI occur error?

TravisBuddy · 2020-09-08T09:29:44Z

Travis tests have failed

Hey @shellhub,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: d29c1380-f1b5-11ea-ba41-b1d3a642fad8

cclauss · 2020-09-08T09:48:42Z

Probably trailing whitespace deleted in doctests.

realDuYuanChao · 2020-09-08T10:11:48Z

How to solve？😭

cclauss · 2020-09-08T10:14:30Z

See which files are failing in Travis CI and then undo the changes to those files.

realDuYuanChao · 2020-09-08T14:45:07Z

Yes. I found why build error was occur. Because whitespace deleted in doctests. Should I update origin source code and commit again? have you any better suggestion? @cclauss

TravisBuddy · 2020-09-08T15:10:41Z

Travis tests have failed

Hey @shellhub,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: 5134a1b0-f1e5-11ea-ba41-b1d3a642fad8

TravisBuddy · 2020-09-08T15:49:52Z

Travis tests have failed

Hey @shellhub,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: ece4a470-f1ea-11ea-ba41-b1d3a642fad8

TravisBuddy · 2020-09-08T16:14:59Z

Travis tests have failed

Hey @shellhub,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: 58945cd0-f1ee-11ea-ba41-b1d3a642fad8

spamegg1 · 2020-09-09T06:21:16Z

The build log is very difficult to understand.
It's showing all kinds of errors from OTHER files.
What is going on?
Also it says above "60 files changed" in shellhub:dev branch, was this your intention @shellhub ?
I suppose this was caused by the forced push that applied psf/black to everything?
It might be best to just start over with 1 file changed.

cclauss · 2020-09-09T06:52:35Z

This was more than just running black. In the cases of the failing doctests, whitespace has been removed from the end of lines which the doctest needs to see for an exact match. This is one of the reasons why black will not suppress trailing whitespace that appears inside of triple quoted strings. There are three files that fail the Travis doctests. If the changes to those three files are reverted then the tests will pass again.

realDuYuanChao

Added whitespace

traversals/binary_tree_traversals.py

TravisBuddy · 2020-09-09T07:20:09Z

Travis tests have failed

Hey @shellhub,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: c60c3520-f26c-11ea-82b8-f1691ab9f797

cclauss · 2020-09-09T15:32:59Z

My sense is that you add the trailing whitespace and then the autoblack GitHub Action undoes it so the tests fail.

realDuYuanChao · 2020-09-09T15:39:34Z

@cclauss All checks have passed. Can you review again. Thanks :)

cclauss · 2020-09-09T16:00:15Z

I am completely lost by the change to bubble sort! We now require the user to provide length but our algorithm never uses that variable.

realDuYuanChao · 2020-09-09T16:07:12Z

I am completely lost by the change to bubble sort! We now require the user to provide length but our algorithm never uses that variable.

Not exactly. length is optional to user. And we used length in our recursion code.

return list_data if not swapped else bubble_sort(list_data, length - 1)

realDuYuanChao · 2020-09-09T16:10:43Z

Get a maximum value to the end of list for each recursive call. Then recursion sort left elements (length - 1 elements)

cclauss · 2020-09-09T16:31:06Z

Please look at it again. Passing a number around but not actually using it (outside of decrementing it and passing it back to yourself) is a waste of cycles.

realDuYuanChao · 2020-09-09T16:47:38Z

@cclauss you are right. I forget make changes that you mentioned before. I make changes like this. Please review again. Thanks :)

    length = length or len(list_data)
    swapped = False
    for i in range(length - 1):
        if list_data[i] > list_data[i + 1]:
            list_data[i], list_data[i + 1] = list_data[i + 1], list_data[i]
            swapped = True

    return list_data if not swapped else bubble_sort(list_data, length - 1)

realDuYuanChao · 2020-09-09T16:49:54Z

I changed for i in range(len(list_data) - 1): to for i in range(length - 1):

cclauss · 2020-09-10T08:31:00Z

OK... Here is what we are going to do. I will land this now. From now on, no PRs that touch so many files.

Please create a new PR for bubble sort that has both the old algorithm and the "oprimized" version in a single file with a timeit (or similar) benchmark that measures the relative performance of each.

cclauss

LGTM

* optimized recursive_bubble_sort * Fixed doctest error due whitespace * reduce loop times for optimization * fixup! Format Python code with psf/black push Co-authored-by: github-actions <${GITHUB_ACTOR}@users.noreply.github.com>

realDuYuanChao requested a review from cclauss September 8, 2020 07:06

cclauss reviewed Sep 8, 2020

View reviewed changes

sorts/recursive_bubble_sort.py Outdated Show resolved Hide resolved

cclauss reviewed Sep 8, 2020

View reviewed changes

sorts/recursive_bubble_sort.py Outdated Show resolved Hide resolved

realDuYuanChao commented Sep 8, 2020

View reviewed changes

sorts/recursive_bubble_sort.py Outdated Show resolved Hide resolved

realDuYuanChao commented Sep 8, 2020

View reviewed changes

sorts/recursive_bubble_sort.py Outdated Show resolved Hide resolved

optimized recursive_bubble_sort

2528bcb

realDuYuanChao commented Sep 9, 2020

View reviewed changes

traversals/binary_tree_traversals.py Outdated Show resolved Hide resolved

Fixed doctest error due whitespace

13952c9

realDuYuanChao and others added 2 commits September 10, 2020 00:43

reduce loop times for optimization

b0acd82

fixup! Format Python code with psf/black push

eaa5c9c

realDuYuanChao requested a review from cclauss September 10, 2020 03:30

cclauss approved these changes Sep 10, 2020

View reviewed changes

cclauss merged commit 4d0a8f2 into TheAlgorithms:master Sep 10, 2020

realDuYuanChao deleted the dev branch September 10, 2020 08:49

Uh oh!

Comments

Conversation

realDuYuanChao commented Sep 8, 2020

Describe your change:

Checklist:

Uh oh!

realDuYuanChao commented Sep 8, 2020

Uh oh!

Uh oh!

Uh oh!

realDuYuanChao left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

TravisBuddy commented Sep 8, 2020

TravisBuddy Request Identifier: cb2f0a90-f1af-11ea-ba41-b1d3a642fad8

Uh oh!

TravisBuddy commented Sep 8, 2020

TravisBuddy Request Identifier: ec7590c0-f1af-11ea-ba41-b1d3a642fad8

Uh oh!

TravisBuddy commented Sep 8, 2020

TravisBuddy Request Identifier: 18cf7a50-f1b0-11ea-ba41-b1d3a642fad8

Uh oh!

TravisBuddy commented Sep 8, 2020

TravisBuddy Request Identifier: 3c4e1630-f1b0-11ea-ba41-b1d3a642fad8

Uh oh!

cclauss commented Sep 8, 2020

Uh oh!

realDuYuanChao left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

TravisBuddy commented Sep 8, 2020

Travis tests have failed

TravisBuddy Request Identifier: 97257ab0-f1b2-11ea-ba41-b1d3a642fad8

Uh oh!

realDuYuanChao commented Sep 8, 2020

Uh oh!

TravisBuddy commented Sep 8, 2020

Travis tests have failed

TravisBuddy Request Identifier: d29c1380-f1b5-11ea-ba41-b1d3a642fad8

Uh oh!

cclauss commented Sep 8, 2020

Uh oh!

realDuYuanChao commented Sep 8, 2020

Uh oh!

cclauss commented Sep 8, 2020

Uh oh!

realDuYuanChao commented Sep 8, 2020

Uh oh!

TravisBuddy commented Sep 8, 2020

Travis tests have failed

TravisBuddy Request Identifier: 5134a1b0-f1e5-11ea-ba41-b1d3a642fad8

Uh oh!

TravisBuddy commented Sep 8, 2020

Travis tests have failed

TravisBuddy Request Identifier: ece4a470-f1ea-11ea-ba41-b1d3a642fad8

Uh oh!

TravisBuddy commented Sep 8, 2020

Travis tests have failed

TravisBuddy Request Identifier: 58945cd0-f1ee-11ea-ba41-b1d3a642fad8

Uh oh!

spamegg1 commented Sep 9, 2020

Uh oh!

cclauss commented Sep 9, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

realDuYuanChao left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

TravisBuddy commented Sep 9, 2020

Travis tests have failed

TravisBuddy Request Identifier: c60c3520-f26c-11ea-82b8-f1691ab9f797

Uh oh!

cclauss commented Sep 9, 2020

Uh oh!

realDuYuanChao commented Sep 9, 2020

Uh oh!

cclauss commented Sep 9, 2020 •

edited

Loading

realDuYuanChao commented Sep 9, 2020 •

edited

Loading

cclauss commented Sep 10, 2020 •

edited

Loading