improve: enhance remote configuration error message#965
Merged
aduh95 merged 1 commit intonodejs:mainfrom Nov 9, 2025
Merged
Conversation
Contributor
tawseefnabi
commented
Aug 9, 2025
tawseefnabi
commented
- Suggest 'upstream' as the default remote name
- Clarify the need to add the remote manually for security
- Provide a clear example of the git remote add command
- Suggest 'upstream' as the default remote name - Clarify the need to add the remote manually for security - Provide a clear example of the git remote add command
aduh95
reviewed
Oct 12, 2025
Comment on lines
+388
to
+389
| '1. First, add the Node.js core repository as a remote (if not already added):\n' + | ||
| ' $ git remote add upstream https://github.com/nodejs/node.git\n\n' + |
Contributor
There was a problem hiding this comment.
I guess we could simply run git remote -v to check whether it's been added, and only show that message if it hasn't.
aduh95
approved these changes
Nov 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.