Conversation
Optimized the `stop()` method in `CopilotClient` to destroy all active sessions in parallel using `Promise.all`. Previously, sessions were destroyed sequentially, leading to a linear increase in shutdown time as the number of sessions grew. With this change, the total time for session destruction is approximately the duration of the slowest individual destruction. Measurements: - 10 sessions with 100ms destruction delay: - Before: ~1000ms - After: ~100ms - Performance gain: ~10x for 10 sessions. The individual retry logic and exponential backoff for each session are preserved. All failures are still collected and reported. Co-authored-by: AkCodes23 <135016848+AkCodes23@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
There was a problem hiding this comment.
Pull request overview
Improves shutdown performance in the Node.js SDK by parallelizing session cleanup in CopilotClient.stop() so session destruction time does not grow linearly with the number of active sessions.
Changes:
- Parallelized session destruction by running per-session retry/backoff logic concurrently via
Promise.all. - Preserved existing behavior of collecting and returning cleanup errors after all session-destruction attempts finish.
- Added a Bolt learning note documenting the cross-SDK pattern and recommended parallel cleanup approach.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| nodejs/src/client.ts | Updates CopilotClient.stop() to destroy all active sessions in parallel while preserving retry/backoff and aggregating errors. |
| .jules/bolt.md | Documents the sequential-destruction performance issue and the recommended parallel cleanup strategy across SDKs. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
1 participant
⚡ Bolt: Parallelize session destruction in Node.js SDK
Optimized the
stop()method inCopilotClientto destroy all active sessions in parallel usingPromise.all.Previously, sessions were destroyed sequentially, leading to a linear increase in shutdown time as the number of sessions grew. This was especially problematic given the existing retry logic and exponential backoff for each session destruction attempt.
With this change, the total time for session destruction is now independent of the number of sessions.
Measurements (using a mock benchmark):
The implementation ensures that:
this.sessionsis cleared only after all destruction attempts have finished.Verified with existing unit tests and client E2E tests.
PR created automatically by Jules for task 13836018781846015088 started by @AkCodes23