Conversation
… are selected. Fixes issue where show was true, but no tiles were selected, the old draw command would still be submitted. Since splats are projected in view space, they still appeared whereever the camera was.
|
Thank you for the pull request, @keyboardspecialist! ✅ We can confirm we have a CLA on file for you. |
Contributor
|
Much better! Looks great. Thanks @keyboardspecialist! |
ggetz
approved these changes
Aug 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes issue where
tileset.showwas true, buttileset._selectedTileswas0and the tileset's draw command would still be submitted. The problem is splats are projected into camera space, so regardless of the where the camera was they would appear. This adds an early exit check if the tileset is not showing or has no tiles in the current view space.This could lead to a "double vision" error if you were zooming or jumping between multiple datasets in different locations on the globe.
Issue number and link
Testing plan
You can load any two or more Gaussian splat assets and jump between them to reproduce.
Viewspace Error Sandcastle
Fixed Sandcastle
Author checklist
CONTRIBUTORS.mdCHANGES.mdwith a short summary of my change