chore: deprecate IE related functions from FeatureDetection.js#13158
chore: deprecate IE related functions from FeatureDetection.js#13158jjspace merged 6 commits intoCesiumGS:mainfrom
Conversation
|
Thank you for the pull request, @MohammadShujaullah! ✅ We can confirm we have a CLA on file for you. |
|
This PR successfully removes all IE-related functions from FeatureDetection.js as requested in issue #12615. Changes include:
Note: Some unrelated test failures are occurring in StaticGeometryPerMaterialBatchSpec.js (unrelated to IE removal). These appear to be pre-existing issues or side effects from the IE removal that affect other parts of the codebase. The core IE deprecation task has been completed successfully. |
|
There are some flaky tests (and some test failures are usually handled with "re-run CI until they pass"). But the current build failures seem to be related to this PR. For example, this should be the current state of this PR: - and it is still using theisInternetExplorer function. (Note: I haven't checked out this state and done a full-text search, but from the output, it looks like there still are a few places where this function is still called)
|
|
Hi! I've addressed the remaining IE function calls that were identified in the PR review. The changes include: 1 Removed IE-specific conditional logic in Vector3DTilePolylines.js and Vector3DTileClampedPolylines.js for the CLIP_POLYLINE shader define All IE-related functionality has now been completely removed as requested in issue #12615, since IE support was discontinued in Cesium 1.84. The changes maintain the same functionality for supported browsers while removing the obsolete IE-specific code paths. |
jjspace
left a comment
There was a problem hiding this comment.
Thanks @MohammadShujaullah, changes look good to me. I just pushed a small commit to remove some extra lines and combine a few variables that I noticed could be combined safely to clean up the code.
#Fixes12615
Description
Deprecates the Internet Explorer detection helpers in FeatureDetection:
FeatureDetection.isInternetExplorer() now always returns false and is marked @deprecated.
FeatureDetection.internetExplorerVersion() now always returns undefined and is marked @deprecated.
This also removes now-unnecessary user agent parsing for Internet Explorer, simplifying the feature detection code path.
Cesium no longer supports Internet Explorer, so these helpers no longer need to perform real detection.
Testing
No behavioral change expected for supported browsers.