Fix Gaussian Splat race condition problem#13189
Draft
danielzhong wants to merge 5 commits intomainfrom
Draft
Conversation
|
Thank you for the pull request, @danielzhong! ✅ We can confirm we have a CLA on file for you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes a race condition in Gaussian splat sorting / snapshot updates that caused WebGL errors, flickering, and inconsistent LOD loading. The update pipeline is now guarded against stale async results and against sorter unavailability during WASM init, which previously left the system stuck in a partial state.
Issue
Vertex buffer is not big enough for the draw callis non-deterministic and easier to trigger during loading + camera interaction, which is typical of a race rather than a deterministic size limit.Fixes
Result:
Issue number and link
Testing plan
Author checklist
CONTRIBUTORS.mdCHANGES.mdwith a short summary of my change