Show An Alert If No Changes Available When Using Discard All Changes

[phlpsong]

Description

Related Issues

• 🐞 Discard All Changes should have an alert when there are no changes #1641

Checklist

• I read and understood the contributing guide as well as the code of conduct
• The issues this PR addresses are related to each other
• My changes generate no new warnings
• My code builds and runs on my machine
• My changes are all related to the related issue above
• I documented my code

Screenshots

discard_changes_alert.mov

[austincondiff]

Instead of creating a new Alert, we should simply disable the Discard Changes menu item.

[austincondiff]

I take that back, I didn't realize this is what Xcode does

[phlpsong]

Instead of creating a new Alert, we should simply disable the Discard Changes menu item.

Yes, this is my first thought. But after comparing with Xcode and try the Stash Changes in our app, I think this behavior is more consistent with them.

[austincondiff]

In my defense, Empty Trash is disabled when the trash is empty...

[phlpsong]

Yes, in most cases we simply disable the button 😁

[matthijseikelenboom]

I'll approve it because it has been made now anyway, but this is nitpicking for the sake of nitpicking.

If disabling a button is just as effective and results in less code (therefore less complexity), that's fine.

"But Xcode ..." doesn't fly for me in these cases