feat: added SidebarItem and selected state#18
Closed
MarcoCarnevali wants to merge 1 commit intoCodeEditApp:mainfrom
Closed
feat: added SidebarItem and selected state#18MarcoCarnevali wants to merge 1 commit intoCodeEditApp:mainfrom
MarcoCarnevali wants to merge 1 commit intoCodeEditApp:mainfrom
Conversation
Member
|
Due to the padding on the button, the spacing between the items is larger than the spacing between folders. Something to take in consideration. But overall it looks nice! |
Collaborator
|
Member
|
When not in focus it's the NSColor.separatorColor |
Collaborator
|
It doesn't look like a separatorColor try a different color name for that. |
Collaborator
|
Use Xcode for reference. It should look identical. |
a8749b0 to
185146a
Compare
Collaborator
Author
Member
Collaborator
Author
Collaborator
Author
|
I'm closing this PR since @lukepistrol seems to have a better and neat solution!! |
xinix909
pushed a commit
to xinix909/CodeTransfer
that referenced
this pull request
Sep 7, 2024
added link to `Add-Languages` inside `CodeLangauge` docs
vksvicky
added a commit
to vksvicky/CodeEdit
that referenced
this pull request
Feb 1, 2026
… tests; git status skip unknown types; lint fixes - Add wrappedLineIndent setting and UI in Text Editing preferences - Add TextEditingSettingsTests for wrapped line indent - GitClient+Status: skip unknown porcelain v2 entry types instead of throwing - Lint: shorten doc comment, strip trailing whitespace in WorkspaceView - CodeFileView: pass wrappedLineIndent when using local CodeEditSourceEditor
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


This PR adds a new

SidebarItemfile inside the main target that should help isolate the view for the sidebar single file item. It now also has a knowledge of if the item is selected or not. This let us implement a different UI based on if the file is selected or not.