Fix breadcrumb display having folders with same name#216
Merged
lukepistrol merged 1 commit intoCodeEditApp:mainfrom Mar 24, 2022
Merged
Fix breadcrumb display having folders with same name#216lukepistrol merged 1 commit intoCodeEditApp:mainfrom
lukepistrol merged 1 commit intoCodeEditApp:mainfrom
Conversation
lukepistrol
approved these changes
Mar 23, 2022
Member
|
Do you know why the tests are not appearing 😮 Edit: Ok seems GitHub Actions are down https://www.githubstatus.com |
Member
|
please push again so the tests trigger |
RayZhao1998
force-pushed
the
bugfix/fix-breakcrumb
branch
from
66a9cbb to
a435345
Compare
Collaborator
Author
|
All tests passed. @lukepistrol can merge now. |
| components.removeLast() | ||
| guard let projURL = workspace.fileURL else { return } | ||
| let components = file.url.path | ||
| .replacingOccurrences(of: projURL.path, with: "") |
Collaborator
There was a problem hiding this comment.
Let's start adding some comments here that explains why we are splitting, mapping and dropping. Something short that will help future us understanding the decision! Great Work!
Collaborator
Author
There was a problem hiding this comment.
😀 I'll do that later.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fix #215
Releated Issue
#215
Checklist (for drafts):
Screenshots (if appropriate):