Invalidate Correct Edited Range#279
Merged
thecoolwinter merged 2 commits intoCodeEditApp:mainfrom Nov 21, 2024
Merged
Conversation
austincondiff
previously approved these changes
Nov 21, 2024
Collaborator
|
Fix the failed test first and then we can merge. |
Collaborator
Author
Fixed! Had to update a test for that method that used different range/delta semantics than |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In the highlight state, invalidates the correct range when performing an edit.
Sometimes tree-sitter doesn't invalidate the ranges that were edited, so we need to add that edited range in. This ensures that a non-empty range is always invalidated.
Related Issues
Checklist
Screenshots
Screen.Recording.2024-11-20.at.10.35.57.PM.mov
Previously:
Screen.Recording.2024-11-20.at.10.36.57.PM.mov