Merged
Conversation
instantepiphany
approved these changes
Mar 4, 2025
instantepiphany
left a comment
instantepiphany
left a comment
There was a problem hiding this comment.
Looks good - just need to fix the array formatting and as long as this builds on your machine we can merge 👍🏻
package.nix
Outdated
| version = displayrUtils.extractRVersion (builtins.readFile ./DESCRIPTION); | ||
| src = ./.; | ||
| description = "Create interactive web graphics from 'ggplot2' graphs and/or a custom interface to the (MIT-licensed) JavaScript library 'plotly.js' inspired by the grammar of graphics."; | ||
| propagatedBuildInputs = with pkgs.rPackages; [ tools scales httr jsonlite magrittr digest viridisLite base64enc htmltools htmlwidgets tidyr RColorBrewer dplyr vctrs tibble lazyeval rlang crosstalk purrr data_table promises ]; |
There was a problem hiding this comment.
If an array has more than a couple elements, we should use the one element per line formatting like:
foo = [
bar
baz
boo
];
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As part of the R Server CI/CD uplift, this task is to package plotly in Nix to make R server CI/CD more reliable and reproducible. To build it, see https://github.com/Displayr/NixR