Fix needs resolution across stages (approval jobs) #2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug in JobDAG dependency resolution when stage prefixing is enabled: needs references (job_id like "build/build_app_image") should match across stages, but were incorrectly restricted to the same stage.\n\nThis could break approval job wiring when approvals live in a different stage than the job they gate.\n\nChanges:\n- Resolve job.needs by matching candidate.job_id regardless of stage when comparing against needed_job_id.\n- Added clarifying comments.\n\nTests: cargo test
Summary by CodeRabbit