fix: increase batch translation timeout to 300#4357
Merged
Conversation
google-cla
bot
added
the
cla: yes
tmatsuo
reviewed
Jul 22, 2020
Contributor
tmatsuo
left a comment
tmatsuo
left a comment
There was a problem hiding this comment.
I think there is another variant. I thought the name was batch_translate_test_with_glossaries or sth.
Does it make sense to bump there as well?
tmatsuo
approved these changes
Jul 22, 2020
Contributor
Author
|
Good call! Yes, let's bump the timeout on batch translate w/ glossary too. |
tmatsuo
approved these changes
Jul 22, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR increases the timeout for the
translate_v3_batch_translate_text_testfrom 240 to 300.Fixes #4221
Fixes #4239