fix: Ctrl+D inside a layer's sub-graph causes the parent layer to be placed inside itself

[Annonnymmousss]

Closes #3809

[gemini-code-assist]

Summary of Changes

Hello @Annonnymmousss, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a critical bug related to layer duplication within sub-graphs. Previously, duplicating a layer using Ctrl+D while inside a sub-graph would result in an erroneous placement of the parent layer within itself. The fix ensures that all relevant layer manipulation functions correctly account for the active sub-graph context, preventing this invalid document structure and improving the reliability of the duplication feature.

Highlights

• Bug Fix: Ctrl+D Duplication in Sub-graphs: Resolved an issue where using Ctrl+D to duplicate a layer within a sub-graph would incorrectly place the parent layer inside itself, leading to an invalid document state.
• Contextual Layer Operations: Modified layer duplication logic to correctly utilize the selection_network_path when identifying unique layers, tracing upstream node flow, and copying nodes, ensuring operations respect the current sub-graph context.

Changelog

• editor/src/messages/portfolio/document/document_message_handler.rs
  • Updated shallowest_unique_layers to consider the selection_network_path for accurate layer identification within sub-graphs.
  • Modified upstream_flow_back_from_nodes to pass the selection_network_path, ensuring correct node flow tracing within the current context.
  • Adjusted copy_nodes to utilize the selection_network_path for proper node duplication within the active sub-graph.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request addresses a bug that occurs when duplicating layers within a subgraph. The fix correctly scopes the duplication logic to the current network context by passing self.selection_network_path to shallowest_unique_layers, upstream_flow_back_from_nodes, and copy_nodes. The changes are consistent and effectively resolve the issue. The code is clean and the fix is well-targeted. Great work!