Closed
Conversation
Allow dosing above an initialThreshold, which can be below suspendThreshold. For dosing decisions, initialThreshold applies to an initial portion of effect duration. All changes are in DoseMath. initialThreshold is hard coded (in two locations) to 10 mg/dL below suspendThreshold, and is used during initial 10% of effect duration.
|
It may actually be nicer to have a gradient instead of a threshold, ie. do something like: units = units * min(currentGlucoseValue - suspendThreshold, 0) / (initialThreshold - suspendThreshold) |
|
Any chance of this making its way into dev branch, or has the code changed so much since then that there are too many conflicts? Thanks |
Collaborator
|
I don't think this will be able to land in mainline Loop; having Loop suggest insulin when you're low is risky. You can always override what Loop suggests. In the future we may have a bolus interface that visually shows you what Loop thinks will happen with a specified dose amount, and you could use that as a guideline for how much to dose in these situations. |
ps2
added a commit
that referenced
this pull request
Oct 27, 2024
…cking (#712) * Update Loop for LoopKit api changes for avoiding thread blocking * Fix non-deterministic test behavior * Updates to use latest LoopAlgorithm package
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pete this is my first pull request. I am not sure I have configured this to work right with mmol though the code is essentially mimicked through all the files after suspend threshold. The basic premise here, and it works in testing for a month is that you can now set a separate bolus threshold that will allow a bolus between bolus and suspend threshold numbers where loop would otherwise still zero temp. Any feedback appreciated. DM61 did the coding to set the feature up, my code was to make it configurable from loop instead of hardcoding a number as he had.