fix(DanaKit): prevent app crash during pump deletion#308
Merged
marionbarker merged 1 commit intoLoopKit:feat/danafrom Aug 12, 2025
Merged
fix(DanaKit): prevent app crash during pump deletion#308marionbarker merged 1 commit intoLoopKit:feat/danafrom
marionbarker merged 1 commit intoLoopKit:feat/danafrom
Conversation
marionbarker
approved these changes
Aug 12, 2025
Contributor
marionbarker
left a comment
marionbarker
left a comment
There was a problem hiding this comment.
Thanks for the fix. I confirmed this works as expected when adding and removing a Dana pump using the Dana simulator.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The app crash was caused by Loop trying to dismiss a UI element without running on the main thread.
Simple fix was implemented to move the code to the main thread before running:
completionDelegate.completionNotifyingDidComplete(self)