Update python_requires to match supported python versions#543
Update python_requires to match supported python versions#543methane merged 1 commit intoPyMySQL:mainfrom gopackgo90:patch-1
Conversation
Codecov Report
@@ Coverage Diff @@
## main #543 +/- ##
=======================================
Coverage 86.00% 86.00%
=======================================
Files 6 6
Lines 550 550
=======================================
Hits 473 473
Misses 77 77 Continue to review full report at Codecov.
|
|
Those commit drop only official support. It doesn't mean current mysqlclient doesn't work with Python 3.6. |
|
You're already preventing users from installing the latest version of this library on Python 3.5. What makes Python 3.6 so special that despite dropping official support for/testing on it you still want to allow users to try installing it in their Python 3.6 environments? If you want to allow users to keep installing the latest versions on Python 3.6, why drop official support for it at all? The only change looked to be that you stopped advertising support for it and stopped automated testing against it. If at some point a user would have an issue installing/using this library on Python 3.6, would you work on resolving that issue? If not, then why let users shoot themselves in the foot? If so, why drop "official" support for Python 3.6 if you would support resolving issues related to it anyways? And no, I don't think |
|
I don't remember correctly, but there were several reasons I want to drop Python 3.5. For example, this commit drop Python 3.5 support. So I am sure that current code don't work with Python 3.5. On the other hand, I don't have explicit reason to block installing for Python 3.6. |
In 684dcbf and dac24e7 it looks like Python 3.6 support has been dropped. This change updates
python_requiresto match so tools likepipknow not to install the next version in a Python 3.6 environment.