Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #564 +/- ##
==========================================
+ Coverage 86.00% 86.10% +0.10%
==========================================
Files 6 6
Lines 550 554 +4
==========================================
+ Hits 473 477 +4
Misses 77 77
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
|
@methane do you have any opinions on this change? I do not want to publish a fork to PyPI, but we are in an impossible situation due to this behavior. |
|
@methane any chance you could look at this? |
|
@methane please take a look, as it is a pressing issue also for me |
|
@methane checking on this again. It is causing major breakage and customer support issues for us. I have no choice but to publish a fork to PyPI and then change the Django and Wagtail documentation to direct users to the fork instead of the official package. I really DO NOT want to do this - relying on a fork is worse for everybody! If you need help maintaining the package, by all means get in touch and I would be happy to volunteer. My email is salvino@coderedcorp.com. |
|
I'm very busy for now. I will take it in a month. |
|
Use |
|
For the record, I confirmed that MySQL Connector/Python does two queries too. |
|
In the future I would like to try changing the MariaDB and MySQL C libraries to accept collation when setting the character set, to reduce this to a single query, as I think that would be the most "proper" fix. However that would be a breaking API change or require adding a new API; so I imagine it would be unlikely to happen, or require a long time and much debate. Thanks for your help. |
|
When will the new version be released? |
|
Update for anyone following, I published this change as |
Fixes #563
This change does not affect existing behavior if the
collateoption is not specified.To test this out locally, e.g. in a Django project:
pip install git+https://github.com/vsalvino/mysqlclient.git