Log request times for partners API and other HTTP fetch#978
Merged
gonzaloriestra merged 4 commits intomainfrom Dec 23, 2022
Merged
Log request times for partners API and other HTTP fetch#978gonzaloriestra merged 4 commits intomainfrom
gonzaloriestra merged 4 commits intomainfrom
Conversation
This comment has been minimized.
This comment has been minimized.
alvaro-shopify
approved these changes
Dec 23, 2022
gonzaloriestra
approved these changes
Dec 23, 2022
Contributor
Coverage report
Show files with reduced coverage 🔻
Test suite run success867 tests passing in 439 suites. Report generated by 🧪jest coverage report action from 23b1cc8 |
Contributor
|
I've added explicit imports for the performance object because tests were failing for Node 14 (it was made a global in v16). Also, I've added the time to each debug message. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Tracing performance of HTTP requests gives us visibility into what's taking the most time. Let's make the CLI faster.
WHAT is this pull request doing?
Using the JS
performanceAPI, grab timestamps before and after the request, and print the total request time.How to test your changes?
Run
devwith--verboseand see the extra log lines! (search forcompleted)Measuring impact
How do we know this change was effective? Please choose one:
Checklist
devordeployhave been reflected in the internal flowchart.