Added the algorithm to compute the terminal velocity of an object fal…#10237
Merged
tianyizheng02 merged 6 commits intoTheAlgorithms:masterfrom Oct 23, 2023
Merged
Added the algorithm to compute the terminal velocity of an object fal…#10237tianyizheng02 merged 6 commits intoTheAlgorithms:masterfrom
tianyizheng02 merged 6 commits intoTheAlgorithms:masterfrom
Conversation
Contributor
Author
|
Could someone please review this pull request. |
tianyizheng02
requested changes
Oct 23, 2023
physics/terminal_velocity.py
Outdated
| raise ValueError( | ||
| "mass, density, area and the drag coefficient all need to be positive" | ||
| ) | ||
| return ((2 * mass * 9.8) / (density * area * drag_coefficient)) ** 0.5 |
Contributor
There was a problem hiding this comment.
Instead of using a hard-coded 9.8 for the acceleration due to gravity, could you import the constant from scipy.constants? The constant value in this library is more accurate.
Contributor
Author
There was a problem hiding this comment.
sure , I'll import the value of g and commit the changes
pluto-tofu
force-pushed
the
terminal_velocity
branch
from
578728f to
0ca5e82
Compare
pluto-tofu
force-pushed
the
terminal_velocity
branch
from
f7f347c to
2cd825f
Compare
algorithms-keeper
bot
added
tests are failing
tianyizheng02
approved these changes
Oct 23, 2023
algorithms-keeper
bot
removed
the
awaiting reviews
Contributor
|
Thanks for your contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ling in a fluid
Describe your change:
Checklist: