added rkf45 method#10438
Merged
cclauss merged 19 commits intoTheAlgorithms:masterfrom Oct 15, 2023
ravi-ivar-7:algo_maths
Merged
added rkf45 method#10438cclauss merged 19 commits intoTheAlgorithms:masterfrom ravi-ivar-7:algo_maths
cclauss merged 19 commits intoTheAlgorithms:masterfrom
ravi-ivar-7:algo_maths
Conversation
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
ravi-ivar-7
commented
Oct 14, 2023
Contributor
Author
ravi-ivar-7
left a comment
ravi-ivar-7
left a comment
There was a problem hiding this comment.
Removed whitespace
Contributor
Author
|
removed some whitespace |
cclauss
reviewed
Oct 14, 2023
cclauss
reviewed
Oct 14, 2023
for more information, see https://pre-commit.ci
ravi-ivar-7
commented
Oct 14, 2023
Contributor
Author
ravi-ivar-7
left a comment
ravi-ivar-7
left a comment
There was a problem hiding this comment.
updated rkf45.py as per suggestions
Contributor
Author
|
updated rkf45.py as per suggestions |
cclauss
requested changes
Oct 14, 2023
maths/rkf45.py
Outdated
| #excact value of y[1] is tan(0.2) = 0.2027100355086 | ||
| >>> def f(x,y): | ||
| ... return 1+y**2 | ||
| >>> y=rkf45(f,0,0,0.2,1) |
Member
There was a problem hiding this comment.
Suggested change
| >>> y=rkf45(f,0,0,0.2,1) | |
| >>> y=rkf45(f, 0, 0, 0.2, 1) |
algorithms-keeper
bot
added
awaiting changes
algorithms-keeper
bot
added
awaiting reviews
ravi-ivar-7
commented
Oct 15, 2023
Contributor
Author
ravi-ivar-7
left a comment
ravi-ivar-7
left a comment
There was a problem hiding this comment.
Improved Code Quality
algorithms-keeper
bot
removed
the
tests are failing
cclauss
reviewed
Oct 15, 2023
cclauss
reviewed
Oct 15, 2023
maths/rkf45.py
Outdated
Comment on lines
35
to
37
| >>> y=runge_futta_fehlberg_45(f, 0, 0, 0.2, 1) | ||
| >>> y[1] | ||
| 0.2027100937470787 |
Member
There was a problem hiding this comment.
We will need more than one test. What happens if x_initial is set to 5, -5, 5.5?
What happens if step_size is zero or negative?
What happens if x_final is zero or negative?
What happens if ode is 5 instead of being a function?
Let's have a test that raises a RangeError.
Contributor
Author
There was a problem hiding this comment.
- Condition on x_initial and x_final is that x_final should be greater than x_initial. They can be zero , negative or positive.
- Added exception for step_size as it should be positive.
- ode can be a constant function or a function of x and/or y.
ravi-ivar-7
commented
Oct 15, 2023
Contributor
Author
ravi-ivar-7
left a comment
ravi-ivar-7
left a comment
There was a problem hiding this comment.
Added more test cases and exception.
maths/rkf45.py
Outdated
Comment on lines
35
to
37
| >>> y=runge_futta_fehlberg_45(f, 0, 0, 0.2, 1) | ||
| >>> y[1] | ||
| 0.2027100937470787 |
Contributor
Author
There was a problem hiding this comment.
- Condition on x_initial and x_final is that x_final should be greater than x_initial. They can be zero , negative or positive.
- Added exception for step_size as it should be positive.
- ode can be a constant function or a function of x and/or y.
Contributor
Author
|
Added more test cases and exception. |
for more information, see https://pre-commit.ci
algorithms-keeper
bot
removed
the
tests are failing
cclauss
approved these changes
Oct 15, 2023
algorithms-keeper
bot
removed
the
awaiting reviews
Member
|
Nice one! It is great that you deal with invalid input. |
Contributor
Author
|
@cclauss : Please add hacktoberfest-accepted label so that it can be accepted in hacktoberfest. |
cclauss
added
the
hacktoberfest-accepted
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add an algorithm (rkf45) to TheAlgorithms / Python/maths