adding new physics algorithm: center of mass#10743
Merged
cclauss merged 5 commits intoTheAlgorithms:masterfrom Oct 21, 2023
santiditomas:center_of_mass
Merged
adding new physics algorithm: center of mass#10743cclauss merged 5 commits intoTheAlgorithms:masterfrom santiditomas:center_of_mass
cclauss merged 5 commits intoTheAlgorithms:masterfrom
santiditomas:center_of_mass
Conversation
cclauss
requested changes
Oct 21, 2023
Member
There was a problem hiding this comment.
This looks super cool! Nice addition. Please consider adding either namedtuples or dataclasses for Particle and Coord3D (please change those names to suit your use case). This would make the function signature:
def center_of_mass(particles: list[Particle]) -> Coord3D:Here is a bit of code for creating and using namedtuples:
>>> from collections import namedtuple
>>> Particle = namedtuple("Particle", "x y z mass")
>>> p = Particle(1, 2, 3, 4)
>>> p
Particle(x=1, y=2, z=3, mass=4)
>>> p.mass
4
>>> total_mass = sum(particle.mass for particle in particles)
>>> Coord3D = namedtuple("Coord3D", "x y z")
>>> Coord3D(6, 7, 8)
Coord3D(x=6, y=7, z=8)
cclauss
approved these changes
Oct 21, 2023
Member
|
I went back to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your change:
Checklist: