Create ipv4_conversion.py#11008
Merged
cclauss merged 6 commits intoTheAlgorithms:masterfrom Oct 28, 2023
its-tapas:patch-6
Merged
Create ipv4_conversion.py#11008cclauss merged 6 commits intoTheAlgorithms:masterfrom its-tapas:patch-6
cclauss merged 6 commits intoTheAlgorithms:masterfrom
its-tapas:patch-6
Conversation
for more information, see https://pre-commit.ci
15 tasks
cclauss
reviewed
Oct 26, 2023
cclauss
reviewed
Oct 26, 2023
conversions/ipconversion.py
Outdated
| '10.0.0.255' | ||
| """ | ||
|
|
||
| if not (0 <= decimal_ip <= 4294967295): |
Member
There was a problem hiding this comment.
This would not catch 10.0.0.256 which is not a valid IP.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
cclauss
reviewed
Oct 26, 2023
conversions/ipconversion.py
Outdated
| for part in ip_parts: | ||
| decimal_ip = (decimal_ip << 8) + int(part) | ||
|
|
||
| return decimal_ip |
Member
There was a problem hiding this comment.
def alt_ip_to_decimal(ip_address: str) -> int:
return int("0x" + "".join(f"{int(i):02x}" for i in ip_address.split(".")), 16)
algorithms-keeper
bot
removed
the
tests are failing
algorithms-keeper
bot
removed
the
awaiting reviews
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your change:
Closes #9718
Closes #11013
Checklist: