Added doctests to min_cost_string_conversion.py and removed :c specifier#11721
Merged
tianyizheng02 merged 6 commits intoTheAlgorithms:masterfrom Oct 4, 2024
Merged
Conversation
15 tasks
tianyizheng02
approved these changes
Oct 4, 2024
Contributor
tianyizheng02
left a comment
There was a problem hiding this comment.
Apart from one unnecessary comment, everything LGTM
Contributor
|
FYI, the I've already merged that PR, but I'll merge your PR as well since your changes build on that PR by adding doctests. This way, both of you get to have a PR approved. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your change:
I added doctests to the min_cost_string_conversion.py in the strings directory file as part of Hacktoberfest 2024 contributions. I also made a small change to the code by removing the ':c' specifier which made the code fail to run, and seemed necessary only if used on integers for unicode converson, not strings.
This PR contributes to #9943.
Checklist: