Conversation
algorithms-keeper
bot
added
require descriptive names
![algorithms-keeper[bot]](https://avatars-githubusercontent-com-gh.computerqwq.top/in/235834?s=60&v=4){kind=small}
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
| @@ -0,0 +1,34 @@ | |||
| def rotate_array(arr, k): | |||
There was a problem hiding this comment.
Please provide return type hint for the function: rotate_array. If the function does not return a value, please provide the type hint as: def function() -> None:
As there is no test file in this pull request nor any test function or class in the file data_structures/arrays/rotate_array.py, please provide doctest for the function rotate_array
Please provide type hint for the parameter: arr
Please provide type hint for the parameter: k
Please provide descriptive name for the parameter: k
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
algorithms-keeper
bot
removed
the
require type hints
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
| if k < 0: | ||
| k += n | ||
|
|
||
| def reverse(start: int, end: int) -> None: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file data_structures/arrays/rotate_array.py, please provide doctest for the function reverse
algorithms-keeper
bot
removed
the
require tests
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
| from typing import List | ||
|
|
||
|
|
||
| def rotate_array(arr: List[int], k: int) -> List[int]: |
There was a problem hiding this comment.
Please provide descriptive name for the parameter: k
There was a problem hiding this comment.
Single-letter variable names are uncool, as discussed in CONTRIBUTING.md.
algorithms-keeper
bot
added
tests are failing
|
@cclauss hey could you look into this? and see why there's an issue? |
|
@cclauss i have fixed what i needed to fix, now 1 check was skipped. Could you review this? And if everything is good to go, can you merge this pr? |
algorithms-keeper
bot
removed
the
awaiting reviews
2 participants
Description:
This PR adds a utility function
rotate_arraywhich rotates a given list bykpositions. It handles both positive and negative rotation values, as well as cases wherekis larger than the length of the array.Checklist: