recaptchaVerification#2417
recaptchaVerification#2417cclauss merged 19 commits intoTheAlgorithms:masterfrom santoshrajkumar:master
Conversation
|
Hey @santoshrajkumar, TravisCI finished with status TravisBuddy Request Identifier: 86a95150-f4b6-11ea-aaf4-7d25d946cae2 |
|
Cool submission! The Travis tests are failing so please see CONTRIBUTING.md discussion of black and flake8 and variable naming. https://travis-ci.com/github/TheAlgorithms/Python/builds/184017264 |
Shall look into it. Being part of na back end code, there may be issues coming up. |
|
Hey @santoshrajkumar, TravisCI finished with status TravisBuddy Request Identifier: 0692f490-f4ba-11ea-aaf4-7d25d946cae2 |
|
https://travis-ci.com/github/TheAlgorithms/Python/builds/184018231#L294-L307 Most of these can be autofixed by running black on your code. |
Ran black on the code & repushed. |
|
Hey @santoshrajkumar, TravisCI finished with status TravisBuddy Request Identifier: 14851ba0-f4bf-11ea-aaf4-7d25d946cae2 |
|
Hey @santoshrajkumar, TravisCI finished with status TravisBuddy Request Identifier: 17b56210-f4c1-11ea-aaf4-7d25d946cae2 |
santoshrajkumar
left a comment
There was a problem hiding this comment.
tried to resolve in the latest commit
|
Hey @santoshrajkumar, TravisCI finished with status TravisBuddy Request Identifier: a756f1e0-f4c1-11ea-aaf4-7d25d946cae2 |
| verify = response["success"] | ||
|
|
||
| # if verify is true | ||
| if verify == True: |
There was a problem hiding this comment.
See PEP8...
| if verify == True: | |
| if verify: |
| return render(request, "login.html") | ||
| else: | ||
| # if verify is not true, send user back to login page | ||
| return render(request, "login.html") No newline at end of file |
There was a problem hiding this comment.
| return render(request, "login.html") | |
| return render(request, "login.html") | |
That ⛔ sign is because the GitHub editor knows that Python files end with one and only one \n.
|
Hey @santoshrajkumar, TravisCI finished with status TravisBuddy Request Identifier: 14c57140-f4c5-11ea-aaf4-7d25d946cae2 |
|
Hey @santoshrajkumar, TravisCI finished with status TravisBuddy Request Identifier: 9ffc7e30-f4c9-11ea-aaf4-7d25d946cae2 |
|
Hey @santoshrajkumar, TravisCI finished with status TravisBuddy Request Identifier: 30234390-f4ca-11ea-aaf4-7d25d946cae2 |
|
Hey @santoshrajkumar, TravisCI finished with status TravisBuddy Request Identifier: a75eeab0-f4cd-11ea-aaf4-7d25d946cae2 |
|
Hey @santoshrajkumar, TravisCI finished with status TravisBuddy Request Identifier: e090f210-f4cd-11ea-aaf4-7d25d946cae2 |
cclauss
left a comment
There was a problem hiding this comment.
Please get Travis to be green...
https://github.com/TheAlgorithms/Python/blob/master/Travis_CI_tests_are_failing.md
|
Hey @santoshrajkumar, TravisCI finished with status TravisBuddy Request Identifier: 28fe7b50-f4d1-11ea-aaf4-7d25d946cae2 |
|
Hey @santoshrajkumar, TravisCI finished with status TravisBuddy Request Identifier: d8d4fa40-f4d1-11ea-aaf4-7d25d946cae2 |
|
Hey @santoshrajkumar, TravisCI finished with status TravisBuddy Request Identifier: e4e2f4d0-f4d2-11ea-aaf4-7d25d946cae2 |
Travis tests have failedHey @santoshrajkumar, TravisBuddy Request Identifier: 114378a0-f4d4-11ea-aaf4-7d25d946cae2 |
|
Hey @santoshrajkumar, TravisCI finished with status TravisBuddy Request Identifier: e0251740-f4d5-11ea-aaf4-7d25d946cae2 |
Travis tests have been passed, modified bit to make it pass. |
santoshrajkumar
left a comment
There was a problem hiding this comment.
Seems nicer now !
|
May be merged if you'd like to. |
* recaptchaVerification * recaptchaVerification * recaptchaVerification1 * recaptchaVerification2 * recaptchaVerification3 * recaptchaVerification4 * recaptchaVerificatio5 * recaptchaVerificatio5 * recaptchaVerificatio6 * drawOnVideoStreamOpenCV * matrixInverseMCAmethod * fixingImports * recaptchaVerificationfixes * recaptchaVerificationfixes * recaptchaVerificationfixes * recaptchaVerificationfixes * recaptchaVerificationfixes1 * recaptchaVerificationfixes1 * authenticate = login = render = redirect = print Co-authored-by: Christian Clauss <cclauss@me.com>
Describe your change:
Checklist:
Fixes: #{$ISSUE_NO}.