Add GitHub action for pre-commit#2515
Conversation
|
It's working perfectly: https://github.com/TheAlgorithms/Python/pull/2515/checks?check_run_id=1186742542 A few small changes required:
With this in place, we can remove |
- Remove executable bit from files without shebang. I checked those file and it was not needed. - Fix with black
|
I think the name of the file should be lint, what do you think? @cclauss |
cclauss
left a comment
There was a problem hiding this comment.
Simplifying by always using the latest and greatest Python and by dropping names that are less self-documenting than the commands that they run.
|
Why not just add the shebang instead of removing the execution bit? |
I think the current name is good enough. The script runs pre-commit so it should be called pre-commit. |
Co-authored-by: Christian Clauss <cclauss@me.com>
|
Except for the If you think otherwise, I will turn them on? |
* Add GitHub action file for pre-commit * Fix errors exposed by pre-commit hook: - Remove executable bit from files without shebang. I checked those file and it was not needed. - Fix with black * Apply suggestions from code review Co-authored-by: Christian Clauss <cclauss@me.com> Co-authored-by: Christian Clauss <cclauss@me.com>
* Add GitHub action file for pre-commit * Fix errors exposed by pre-commit hook: - Remove executable bit from files without shebang. I checked those file and it was not needed. - Fix with black * Apply suggestions from code review Co-authored-by: Christian Clauss <cclauss@me.com> Co-authored-by: Christian Clauss <cclauss@me.com>
Follow-up on #2511
As mentioned in #2511 (comment)
Describe your change:
Checklist: