Skip to content

Add Project Euler problem 117 solution 1#6872

Merged
dhruvmanila merged 5 commits intoTheAlgorithms:masterfrom
MaximSmolskiy:add-project-euler-problem-117-solution-1
Mar 2, 2023
Merged

Add Project Euler problem 117 solution 1#6872
dhruvmanila merged 5 commits intoTheAlgorithms:masterfrom
MaximSmolskiy:add-project-euler-problem-117-solution-1

Conversation

@MaximSmolskiy
Copy link
Member

@MaximSmolskiy MaximSmolskiy commented Oct 9, 2022

Describe your change:

Add Project Euler problem 117 solution 1:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@algorithms-keeper algorithms-keeper bot added awaiting reviews This PR is ready to be reviewed tests are failing Do not merge until tests pass and removed tests are failing Do not merge until tests pass labels Oct 9, 2022
@MaximSmolskiy MaximSmolskiy requested a review from cclauss as a code owner October 9, 2022 17:42
@MaximSmolskiy MaximSmolskiy force-pushed the add-project-euler-problem-117-solution-1 branch from af684e3 to 2f41327 Compare October 9, 2022 17:45
@algorithms-keeper algorithms-keeper bot added the tests are failing Do not merge until tests pass label Oct 9, 2022
@algorithms-keeper algorithms-keeper bot removed the tests are failing Do not merge until tests pass label Oct 23, 2022
@MaximSmolskiy
Copy link
Member Author

MaximSmolskiy commented Oct 23, 2022

@cclauss @dhruvmanila please review

@cclauss
Copy link
Member

cclauss commented Oct 23, 2022

I don't do Euler.

@MaximSmolskiy
Copy link
Member Author

MaximSmolskiy commented Mar 2, 2023

@dhruvmanila please review

@dhruvmanila dhruvmanila merged commit 9720e6a into TheAlgorithms:master Mar 2, 2023
@algorithms-keeper algorithms-keeper bot removed the awaiting reviews This PR is ready to be reviewed label Mar 2, 2023
@MaximSmolskiy MaximSmolskiy deleted the add-project-euler-problem-117-solution-1 branch March 2, 2023 16:52
Cjkjvfnby pushed a commit to Cjkjvfnby/Python that referenced this pull request Mar 13, 2023
@MaximSmolskiy @Cjkjvfnby
Add Project Euler problem 117 solution 1 (TheAlgorithms#6872)
f55b54e 
Update DIRECTORY.md

---------

Co-authored-by: github-actions <${GITHUB_ACTOR}@users.noreply.github.com>
@isidroas isidroas mentioned this pull request Jan 25, 2025
Closed
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dhruvmanila dhruvmanila dhruvmanila approved these changes

@Kush1101 Kush1101 Awaiting requested review from Kush1101

@cclauss cclauss Awaiting requested review from cclauss

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@MaximSmolskiy @cclauss @dhruvmanila