Refactor mixed_keyword_cypher.py file and added comments in code#8633
Closed
Ranausama420 wants to merge 6 commits intoTheAlgorithms:masterfrom
Closed
Refactor mixed_keyword_cypher.py file and added comments in code#8633Ranausama420 wants to merge 6 commits intoTheAlgorithms:masterfrom
Ranausama420 wants to merge 6 commits intoTheAlgorithms:masterfrom
Conversation
for more information, see https://pre-commit.ci
…ed comments for better understanding
for more information, see https://pre-commit.ci
tianyizheng02
requested changes
Apr 14, 2023
Contributor
tianyizheng02
left a comment
There was a problem hiding this comment.
This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
ankit-gautam23
approved these changes
Apr 18, 2023
ankit-gautam23
left a comment
There was a problem hiding this comment.
Effective changes with neat one liner comment. I don't think it gonna break anywhere in the system.
Contributor
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your change:
changed below lines added sets functionality and remove for loops to get unique element in list
temp = list(set(key))
len_temp = len(temp)
string module can used to generate alphabets list instead of using loops
alpha = list(string.ascii_uppercase)
and used string join method to generate cypher
Resolves #8622
Checklist:
Fixes: #{$ISSUE_NO}.