Skip to content

Comments

Added Altitude Pressure equation#8909

Merged
cclauss merged 19 commits intoTheAlgorithms:masterfrom
Bazifrasool:Altitude-Equation
Jul 30, 2023
Merged

Added Altitude Pressure equation#8909
cclauss merged 19 commits intoTheAlgorithms:masterfrom
Bazifrasool:Altitude-Equation

Conversation

@Bazifrasool
Copy link
Contributor

@Bazifrasool Bazifrasool commented Jul 30, 2023

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".

@algorithms-keeper algorithms-keeper bot added the awaiting reviews This PR is ready to be reviewed label Jul 30, 2023
cclauss
cclauss reviewed Jul 30, 2023
View reviewed changes
.vscode/settings.json Outdated
Comment on lines 5 to 6
"python.linting.pylintEnabled": true,
"python.linting.enabled": true
Copy link
Member

@cclauss cclauss Jul 30, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please revert this change. This repo not use pylint. Instead, we use ruff that includes the pylint rules.

Python/pyproject.toml

Line 111 in d31750a

[tool.ruff.pylint] # DO NOT INCREASE THESE VALUES

@algorithms-keeper algorithms-keeper bot added the tests are failing Do not merge until tests pass label Jul 30, 2023
cclauss
cclauss reviewed Jul 30, 2023
View reviewed changes
@algorithms-keeper algorithms-keeper bot removed the tests are failing Do not merge until tests pass label Jul 30, 2023
cclauss and others added 2 commits July 30, 2023 15:55
@cclauss
Fix again lru_cache_pythonic.py
2a9a4fc
@Bazifrasool @cclauss
Update .vscode/settings.json
a80c46d 
Co-authored-by: Christian Clauss <cclauss@me.com>
@algorithms-keeper algorithms-keeper bot added the tests are failing Do not merge until tests pass label Jul 30, 2023
cclauss
cclauss reviewed Jul 30, 2023
View reviewed changes
@Bazifrasool @cclauss
Update .vscode/settings.json
eeb3186 
Co-authored-by: Christian Clauss <cclauss@me.com>
cclauss
cclauss reviewed Jul 30, 2023
View reviewed changes
cclauss and others added 2 commits July 30, 2023 16:01
@cclauss
4th fix lru_cache_pythonic.py
ef1e63d
@Bazifrasool @cclauss
Update physics/altitude_pressure.py
b88c755 
Co-authored-by: Christian Clauss <cclauss@me.com>
@algorithms-keeper algorithms-keeper bot removed the tests are failing Do not merge until tests pass label Jul 30, 2023
cclauss
cclauss requested changes Jul 30, 2023
View reviewed changes
Copy link
Member

@cclauss cclauss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool algorithm... Just a few more tests.

physics/altitude_pressure.py Outdated
Comment on lines 27 to 28
>>> get_altitude_at_pressure(pressure=100000)
105.47836610778828
Copy link
Member

@cclauss cclauss Jul 30, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make tests for H ~= sea level, H ~= 100 meters (the current test), H ~= 1,750 (altitude of my house) also a zero pressure, a negative pressure, and a pressure greater than 101,325... The last few should prove that the code raises ValueErrors like...

Python/arithmetic_analysis/bisection.py

Lines 9 to 12 in d31750a

>>> bisection(lambda x: x ** 3 - 1, 2, 1000)
Traceback (most recent call last):
...
ValueError: could not find root in given interval.

@algorithms-keeper algorithms-keeper bot removed the awaiting reviews This PR is ready to be reviewed label Jul 30, 2023
@algorithms-keeper algorithms-keeper bot added the awaiting changes A maintainer has requested changes to this PR label Jul 30, 2023
@algorithms-keeper algorithms-keeper bot added tests are failing Do not merge until tests pass and removed tests are failing Do not merge until tests pass labels Jul 30, 2023
cclauss
cclauss reviewed Jul 30, 2023
View reviewed changes
cclauss
cclauss approved these changes Jul 30, 2023
View reviewed changes
Copy link
Member

@cclauss cclauss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice contribution!!!!

@algorithms-keeper algorithms-keeper bot removed the awaiting changes A maintainer has requested changes to this PR label Jul 30, 2023
@cclauss cclauss merged commit 8b831cb into TheAlgorithms:master Jul 30, 2023
@Bazifrasool Bazifrasool deleted the Altitude-Equation branch July 30, 2023 15:07
@isidroas isidroas mentioned this pull request Jan 25, 2025
Closed
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cclauss cclauss cclauss approved these changes

@dhruvmanila dhruvmanila Awaiting requested review from dhruvmanila

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Bazifrasool @cclauss