Conversation
algorithms-keeper
bot
added
require tests
![algorithms-keeper[bot]](https://avatars-githubusercontent-com-gh.computerqwq.top/in/235834?s=60&v=4){kind=small}
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
There was a problem hiding this comment.
Please provide return type hint for the function: __init__. If the function does not return a value, please provide the type hint as: def function() -> None:
Please provide type hint for the parameter: val
| self.parent = None | ||
| self.mark = False | ||
|
|
||
| def add_child(self, child): |
There was a problem hiding this comment.
Please provide return type hint for the function: add_child. If the function does not return a value, please provide the type hint as: def function() -> None:
As there is no test file in this pull request nor any test function or class in the file data_structures/heap/fibonacci_heap.py, please provide doctest for the function add_child
Please provide type hint for the parameter: child
There was a problem hiding this comment.
Please provide return type hint for the function: remove_child. If the function does not return a value, please provide the type hint as: def function() -> None:
As there is no test file in this pull request nor any test function or class in the file data_structures/heap/fibonacci_heap.py, please provide doctest for the function remove_child
Please provide type hint for the parameter: child
There was a problem hiding this comment.
Please provide return type hint for the function: __init__. If the function does not return a value, please provide the type hint as: def function() -> None:
There was a problem hiding this comment.
Please provide return type hint for the function: insert. If the function does not return a value, please provide the type hint as: def function() -> None:
As there is no test file in this pull request nor any test function or class in the file data_structures/heap/fibonacci_heap.py, please provide doctest for the function insert
Please provide type hint for the parameter: val
There was a problem hiding this comment.
Please provide return type hint for the function: _cut. If the function does not return a value, please provide the type hint as: def function() -> None:
As there is no test file in this pull request nor any test function or class in the file data_structures/heap/fibonacci_heap.py, please provide doctest for the function _cut
Please provide type hint for the parameter: node
Please provide type hint for the parameter: parent
There was a problem hiding this comment.
Please provide return type hint for the function: _cascading_cut. If the function does not return a value, please provide the type hint as: def function() -> None:
As there is no test file in this pull request nor any test function or class in the file data_structures/heap/fibonacci_heap.py, please provide doctest for the function _cascading_cut
Please provide type hint for the parameter: node
There was a problem hiding this comment.
Please provide return type hint for the function: delete_node. If the function does not return a value, please provide the type hint as: def function() -> None:
As there is no test file in this pull request nor any test function or class in the file data_structures/heap/fibonacci_heap.py, please provide doctest for the function delete_node
Please provide type hint for the parameter: node
There was a problem hiding this comment.
Please provide return type hint for the function: _update_min_node. If the function does not return a value, please provide the type hint as: def function() -> None:
As there is no test file in this pull request nor any test function or class in the file data_structures/heap/fibonacci_heap.py, please provide doctest for the function _update_min_node
There was a problem hiding this comment.
Please provide return type hint for the function: __str__. If the function does not return a value, please provide the type hint as: def function() -> None:
As there is no test file in this pull request nor any test function or class in the file data_structures/heap/fibonacci_heap.py, please provide doctest for the function __str__
for more information, see https://pre-commit.ci
…thon into fibonacci-heap-branch
algorithms-keeper
bot
removed
the
require type hints
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file data_structures/heap/fibonacci_heap.py, please provide doctest for the function add_child
| child.parent = self | ||
| self.degree += 1 | ||
|
|
||
| def remove_child(self, child: "FibonacciNode") -> None: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file data_structures/heap/fibonacci_heap.py, please provide doctest for the function remove_child
| self.root_list = [] | ||
| self.size = 0 | ||
|
|
||
| def insert(self, val: int) -> None: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file data_structures/heap/fibonacci_heap.py, please provide doctest for the function insert
| self.root_list.append(new_node) | ||
| self.size += 1 | ||
|
|
||
| def _link(self, min_node: FibonacciNode, new_node: FibonacciNode) -> None: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file data_structures/heap/fibonacci_heap.py, please provide doctest for the function _link
| """ | ||
| min_node.add_child(new_node) | ||
|
|
||
| def find_min(self) -> int: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file data_structures/heap/fibonacci_heap.py, please provide doctest for the function find_min
| if node.val < self.min_node.val: | ||
| self.min_node = node | ||
|
|
||
| def _cut(self, node: FibonacciNode, parent: FibonacciNode) -> None: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file data_structures/heap/fibonacci_heap.py, please provide doctest for the function _cut
| self.root_list.append(node) | ||
| node.mark = False | ||
|
|
||
| def _cascading_cut(self, node: FibonacciNode) -> None: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file data_structures/heap/fibonacci_heap.py, please provide doctest for the function _cascading_cut
| self._cut(node, parent) | ||
| self._cascading_cut(parent) | ||
|
|
||
| def delete_node(self, node: FibonacciNode) -> None: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file data_structures/heap/fibonacci_heap.py, please provide doctest for the function delete_node
| self.decrease_key(node, float("-inf")) | ||
| self.delete_min() | ||
|
|
||
| def _update_min_node(self) -> None: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file data_structures/heap/fibonacci_heap.py, please provide doctest for the function _update_min_node
| min_val = min(node.val for node in self.root_list) | ||
| self.min_node = next(node for node in self.root_list if node.val == min_val) | ||
|
|
||
| def __str__(self) -> str: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file data_structures/heap/fibonacci_heap.py, please provide doctest for the function __str__
algorithms-keeper
bot
added
the
require type hints
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
| self.parent = None | ||
| self.mark = False | ||
|
|
||
| def add_child(self, child): |
There was a problem hiding this comment.
Please provide return type hint for the function: add_child. If the function does not return a value, please provide the type hint as: def function() -> None:
Please provide type hint for the parameter: child
| child.parent = self | ||
| self.degree += 1 | ||
|
|
||
| def remove_child(self, child: "FibonacciNode") -> None: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file data_structures/heap/fibonacci_heap.py, please provide doctest for the function remove_child
| self.root_list = [] | ||
| self.size = 0 | ||
|
|
||
| def insert(self, val: int) -> None: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file data_structures/heap/fibonacci_heap.py, please provide doctest for the function insert
| self.root_list.append(new_node) | ||
| self.size += 1 | ||
|
|
||
| def _link(self, min_node: FibonacciNode, new_node: FibonacciNode) -> None: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file data_structures/heap/fibonacci_heap.py, please provide doctest for the function _link
| """ | ||
| min_node.add_child(new_node) | ||
|
|
||
| def find_min(self) -> int: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file data_structures/heap/fibonacci_heap.py, please provide doctest for the function find_min
| if node.val < self.min_node.val: | ||
| self.min_node = node | ||
|
|
||
| def _cut(self, node: FibonacciNode, parent: FibonacciNode) -> None: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file data_structures/heap/fibonacci_heap.py, please provide doctest for the function _cut
| self.root_list.append(node) | ||
| node.mark = False | ||
|
|
||
| def _cascading_cut(self, node: FibonacciNode) -> None: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file data_structures/heap/fibonacci_heap.py, please provide doctest for the function _cascading_cut
| self._cut(node, parent) | ||
| self._cascading_cut(parent) | ||
|
|
||
| def delete_node(self, node: FibonacciNode) -> None: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file data_structures/heap/fibonacci_heap.py, please provide doctest for the function delete_node
| self.decrease_key(node, float("-inf")) | ||
| self.delete_min() | ||
|
|
||
| def _update_min_node(self) -> None: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file data_structures/heap/fibonacci_heap.py, please provide doctest for the function _update_min_node
| self.min_node = next( | ||
| node for node in self.root_list if node.val == min_val) | ||
|
|
||
| def __str__(self) -> str: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file data_structures/heap/fibonacci_heap.py, please provide doctest for the function __str__
for more information, see https://pre-commit.ci
1 participant
Add Fibonacci Heap Implementation in Python
Checklist: