Changing Name of file and adding doctests in file. by AasheeshLikePanner · Pull Request #9513 · TheAlgorithms/Python

AasheeshLikePanner · 2023-10-02T17:26:13Z

Describe your change:

Change the File and Added doctests in Binary Multiplication
Fixes #9478

Add an algorithm?
Fix a bug or typo in an existing algorithm?
Documentation change?

Checklist:

for more information, see https://pre-commit.ci

maths/binary_multiplication.py

tianyizheng02 · 2023-10-02T20:49:28Z

I have edited your PR description. The "fixes" message must look like this for GitHub to automatically link your PR to the issue.

maths/binary_multiplication.py

for more information, see https://pre-commit.ci

AasheeshLikePanner · 2023-10-03T10:52:24Z

Thanks for doing this. I have fixed the issue now Can you please check it now.

AasheeshLikePanner · 2023-10-03T12:03:37Z

It shows you want a change Can you please tell me what change you want?

tianyizheng02

Can you change the description on line 2 to say "Binary Multiplication"? Because this file calculates multiplication, not exponentiation

AasheeshLikePanner · 2023-10-03T13:00:50Z

Hi, Can you check now

tianyizheng02 · 2023-10-03T13:15:41Z

Did you change line 2?

AasheeshLikePanner · 2023-10-03T14:01:35Z

Do you mean to change exponentiation to multiplication in code Here in function name?

In description I already change in discription.

This is my first contributing so, sorry for asking this much questions 😅

tianyizheng02 · 2023-10-03T14:12:09Z

No, I mean line 2.

This should say "Binary Multiplication" because that's what this file does.

However, you are correct that the function names also need to be changed.

AasheeshLikePanner · 2023-10-03T14:24:49Z

I changed function name b_expo to b_multi also change in the second line. Can you tell it is good now?

for more information, see https://pre-commit.ci

algorithms-keeper

Click here to look at the relevant links ⬇️

🔗 Relevant Links

Repository:

Contributing guidelines

Project Euler solution guidelines

Python:

Formatted string literals (f-strings)

Type hints

doctest

unittest

pytest

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.

algorithms-keeper commands and options

algorithms-keeper actions can be triggered by commenting on this PR:

@algorithms-keeper review to trigger the checks for only added pull request files

@algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.

NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.

maths/binary_multiplication.py

algorithms-keeper

Click here to look at the relevant links ⬇️

🔗 Relevant Links

Repository:

Contributing guidelines

Project Euler solution guidelines

Python:

Formatted string literals (f-strings)

Type hints

doctest

unittest

pytest

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.

algorithms-keeper commands and options

algorithms-keeper actions can be triggered by commenting on this PR:

@algorithms-keeper review to trigger the checks for only added pull request files

@algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.

NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.

algorithms-keeper · 2023-10-03T15:35:49Z

maths/binary_multiplication.py

+"""
+
+
+def binary_multiply(a: int, b: int) -> int:


Please provide descriptive name for the parameter: a

Please provide descriptive name for the parameter: b

maths/binary_multiplication.py

tianyizheng02

Fixed the rest of the issues myself

AasheeshLikePanner · 2023-10-03T15:41:23Z

Thanks for giving your valuable time to me.
Sorry If I asked too many silly questions 😅
Have a Nice day

Rename binary_exponentiation_3.py to binary_exponentiation_2.py because the original binary_exponentiation_2.py was renamed to binary_multiplication.py in PR TheAlgorithms#9513

* updating DIRECTORY.md * Rename binary_exponentiation_3.py Rename binary_exponentiation_3.py to binary_exponentiation_2.py because the original binary_exponentiation_2.py was renamed to binary_multiplication.py in PR #9513 * updating DIRECTORY.md * updating DIRECTORY.md * updating DIRECTORY.md * updating DIRECTORY.md --------- Co-authored-by: github-actions <${GITHUB_ACTOR}@users.noreply.github.com>

Adding doctests and changing file name

2c4994c

algorithms-keeper bot added enhancement This PR modified some existing files awaiting reviews This PR is ready to be reviewed labels Oct 2, 2023

[pre-commit.ci] auto fixes from pre-commit.com hooks

90e5eb8

for more information, see https://pre-commit.ci

algorithms-keeper bot added the tests are failing Do not merge until tests pass label Oct 2, 2023

This was referenced Oct 2, 2023

Changing Name of file and adding doctests in file. #9504

Closed

maths/binary_exponentiation_2.py needs to be renamed #9478

Closed

tianyizheng02 requested changes Oct 2, 2023

View reviewed changes

maths/binary_multiplication.py Outdated Show resolved Hide resolved

chriso345 reviewed Oct 2, 2023

View reviewed changes

maths/binary_multiplication.py Outdated Show resolved Hide resolved

AasheeshLikePanner and others added 3 commits October 3, 2023 16:15

Update binary_multiplication.py

85f2cc1

[pre-commit.ci] auto fixes from pre-commit.com hooks

dd16da3

for more information, see https://pre-commit.ci

Update binary_multiplication.py

ff50144

algorithms-keeper bot removed the tests are failing Do not merge until tests pass label Oct 3, 2023

tianyizheng02 requested changes Oct 3, 2023

View reviewed changes

AasheeshLikePanner added 2 commits October 3, 2023 19:51

Changing comment and changing name function

c20642e

Merge remote-tracking branch 'origin/master'

a9d007d

algorithms-keeper bot added the tests are failing Do not merge until tests pass label Oct 3, 2023

AasheeshLikePanner and others added 3 commits October 3, 2023 20:07

Changing comment and changing name function

4b6dfbf

[pre-commit.ci] auto fixes from pre-commit.com hooks

6c0e81f

for more information, see https://pre-commit.ci

Update binary_multiplication.py

629eba0

algorithms-keeper bot removed the tests are failing Do not merge until tests pass label Oct 3, 2023

[pre-commit.ci] auto fixes from pre-commit.com hooks

7570ac6

for more information, see https://pre-commit.ci

Update binary_multiplication.py

caadd29

algorithms-keeper bot added the require descriptive names This PR needs descriptive function and/or variable names label Oct 3, 2023

algorithms-keeper bot reviewed Oct 3, 2023

View reviewed changes

maths/binary_multiplication.py Show resolved Hide resolved

maths/binary_multiplication.py Outdated Show resolved Hide resolved

Update binary_multiplication.py

be6c8b1

algorithms-keeper bot reviewed Oct 3, 2023

View reviewed changes

tianyizheng02 approved these changes Oct 3, 2023

View reviewed changes

tianyizheng02 merged commit 0a84b8f into TheAlgorithms:master Oct 3, 2023

algorithms-keeper bot removed the awaiting reviews This PR is ready to be reviewed label Oct 3, 2023

This was referenced Oct 3, 2023

renaming file binary_exponentiation_2.py #9515

Closed

Renamed maths/binary_exponentiation_2.py to binary_multiplication.py #9521

Closed

Renamed from binary_exponentiation_2.py #9493

Closed

tianyizheng02 mentioned this pull request Oct 4, 2023

Rename maths/binary_exponentiation_3.py #9656

Merged

14 tasks

isidroas mentioned this pull request Jan 25, 2025

dh isidroas/Python#1

Closed

14 tasks

Uh oh!

Conversation

AasheeshLikePanner commented Oct 2, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Describe your change:

Checklist:

Uh oh!

Uh oh!

tianyizheng02 commented Oct 2, 2023

Uh oh!

Uh oh!

AasheeshLikePanner commented Oct 3, 2023

Uh oh!

AasheeshLikePanner commented Oct 3, 2023

Uh oh!

tianyizheng02 left a comment

Choose a reason for hiding this comment

Uh oh!

AasheeshLikePanner commented Oct 3, 2023

Uh oh!

tianyizheng02 commented Oct 3, 2023

Uh oh!

AasheeshLikePanner commented Oct 3, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

tianyizheng02 commented Oct 3, 2023

Uh oh!

AasheeshLikePanner commented Oct 3, 2023

Uh oh!

algorithms-keeper bot left a comment

Choose a reason for hiding this comment

🔗 Relevant Links

Repository:

Python:

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.

algorithms-keeper actions can be triggered by commenting on this PR:

Uh oh!

Uh oh!

Uh oh!

algorithms-keeper bot left a comment

Choose a reason for hiding this comment

🔗 Relevant Links

Repository:

Python:

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.

algorithms-keeper actions can be triggered by commenting on this PR:

Uh oh!

algorithms-keeper bot Oct 3, 2023

Choose a reason for hiding this comment

Uh oh!

Uh oh!

tianyizheng02 left a comment

Choose a reason for hiding this comment

Uh oh!

AasheeshLikePanner commented Oct 3, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

AasheeshLikePanner commented Oct 2, 2023 •

edited

Loading

AasheeshLikePanner commented Oct 3, 2023 •

edited

Loading