Conversation
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
maths/stewart.py
Outdated
There was a problem hiding this comment.
Please provide descriptive name for the parameter: a
Please provide descriptive name for the parameter: b
Please provide descriptive name for the parameter: c
Please provide descriptive name for the parameter: n
Please provide descriptive name for the parameter: m
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
maths/stewart.py
Outdated
There was a problem hiding this comment.
Please provide descriptive name for the parameter: a
Please provide descriptive name for the parameter: b
Please provide descriptive name for the parameter: c
Please provide descriptive name for the parameter: n
Please provide descriptive name for the parameter: m
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
maths/stewart.py
Outdated
There was a problem hiding this comment.
Please provide descriptive name for the parameter: a
Please provide descriptive name for the parameter: b
Please provide descriptive name for the parameter: c
Please provide descriptive name for the parameter: n
Please provide descriptive name for the parameter: m
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
| """ | ||
|
|
||
|
|
||
| def stewart(a: float, b: float, c: float, n: float, m: float) -> float: |
There was a problem hiding this comment.
Please provide descriptive name for the parameter: a
Please provide descriptive name for the parameter: b
Please provide descriptive name for the parameter: c
Please provide descriptive name for the parameter: n
Please provide descriptive name for the parameter: m
for more information, see https://pre-commit.ci
|
To clear out |
Also, you already added the Fletcher16 algorithm in #9775 |
|
@tianyizheng02 Please see my comment above yours. This will happen when users create pull requests on their Our CONTRIBUTING.md should emphasize not creating PRs on the |
Describe your change:
Checklist: