Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
@blocknote/ariakit
@blocknote/code-block
@blocknote/core
@blocknote/mantine
@blocknote/react
@blocknote/server-util
@blocknote/shadcn
@blocknote/xl-ai
@blocknote/xl-docx-exporter
@blocknote/xl-email-exporter
@blocknote/xl-multi-column
@blocknote/xl-odt-exporter
@blocknote/xl-pdf-exporter
commit: |
nperez0111
reviewed
Oct 16, 2025
packages/core/src/api/blockManipulation/commands/replaceBlocks/replaceBlocks.ts
Outdated
Show resolved
Hide resolved
packages/core/src/api/blockManipulation/commands/replaceBlocks/replaceBlocks.ts
Outdated
Show resolved
Hide resolved
…olumns are removed + added more tests
Contributor
|
Where are we at with this @matthewlipski, am I missing the changes you made here? |
Collaborator
Author
Contributor
|
That's what it was. Let's merge that into this & review altogether I think |
* Added `fixColumnList` function * Updated keyboard shortcut * Implemented PR feedback
4 tasks
nperez0111
requested changes
Oct 30, 2025
packages/core/src/api/blockManipulation/commands/replaceBlocks/util/fixColumnList.ts
Outdated
Show resolved
Hide resolved
packages/core/src/api/blockManipulation/commands/replaceBlocks/util/fixColumnList.ts
Outdated
Show resolved
Hide resolved
packages/core/src/api/blockManipulation/commands/replaceBlocks/util/fixColumnList.ts
Show resolved
Hide resolved
packages/core/src/api/blockManipulation/commands/replaceBlocks/util/fixColumnList.ts
Show resolved
Hide resolved
packages/core/src/api/blockManipulation/commands/replaceBlocks/replaceBlocks.ts
Outdated
Show resolved
Hide resolved
Collaborator
Author
IMPORTANT NOTEThere is a known issue with this PR, in that Screen.Recording.2025-10-31.at.16.27.16.mov |
nperez0111
approved these changes
Nov 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Currently, when there is only one block in a column, removing it via
removeBlocks/replaceBlockswon't collapse the column as it should, leading to confusing UX when deleting the block from the side menu. This behavior is also different to removing the block by hitting backspace at its start.This PR makes empty
columns, andcolumnListswith <2 children get collapsed. This happens by running the newfixColumnListfunction inremoveBlocks/replaceBlocks. The Backspace keyboard handler has also been updated to usefixColumnListwhen removing the last block in a column.Closes #1323
Fixes #2000
Rationale
The current behavior of the remove block button in the side menu is unintuitive when used on the only block in a column, and should be improved.
Changes
fixColumnListfunction.removeAndInsertBlocksand Backspace keyboard handler usefixColumnList.Impact
Since
removeAndInsertBlockscan now removecolumn/columnListnodes that it's actively traversing indoc.descendants, there's an edge case where I'm not sure what will happen.E.g. consider this structure:
columnListcolumnblockContainer1columnblockContainer2columnblockContainer3If we call
removeBlocksfor bothblockContainer2 & 3, I'm not sure this will work properly. Worth adding tests for this?EDIT: Added tests, works ok for both removing and replacing blocks 👍
Testing
See above.
Screenshots/Video
N/A
Checklist
Additional Notes