feat: update suggestion menu component#2397
Conversation
|
@MDSAM05 is attempting to deploy a commit to the TypeCell Team on Vercel. A member of the Team first needs to authorize it. |
@blocknote/ariakit
@blocknote/code-block
@blocknote/core
@blocknote/mantine
@blocknote/react
@blocknote/server-util
@blocknote/shadcn
@blocknote/xl-ai
@blocknote/xl-docx-exporter
@blocknote/xl-email-exporter
@blocknote/xl-multi-column
@blocknote/xl-odt-exporter
@blocknote/xl-pdf-exporter
commit: |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
I'm wondering if we're going about the UX of scrolling while the slash menu is open the right way. Notion initially scrolls to the selection/slash menu when opened, but then blocks scrolling the document afterwards. @nperez0111 do you think it makes any sense to replicate that? If we do want to deviate from Notion's UX here and allow users to scroll the document while the slash menu is open, we should also make sure that changing the selected item always scrolls it into view. Currently, this happens inconsistently. For now, I'll merge this PR as it fixes a bug with the scrolling. Depending on what UX solution we decide on, I'll create separate issues later. |
Summary
Fixes unexpected page scrolling when navigating the suggestion menu with keyboard arrow keys, especially when wrapping from the last item to the first (and vice versa).
Rationale
Arrow key navigation caused the page to scroll when wrapping between suggestions, leading to a poor editor experience.
This fix enables smooth circular navigation by keeping focus stable and preventing unwanted scrolling.
Changes
Impact
Testing
Screenshots/Video
Recording.2026-01-29.213625.mp4
Checklist