Construct assemble models for classes with val-properties in constructor #1190#1240
Merged
volivan239 merged 1 commit intomainfrom Oct 31, 2022
Conversation
e106126 to
d5728f6
Compare
d5728f6 to
96587bd
Compare
EgorkaKulikov
approved these changes
Oct 31, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Modified
assembleCompositeModel(UtCompositeModel)so that if final fields exist but they all are set by constructor, then we still try to create assemble model (before PR, any final field meant that model can't be assembled).Fixes #1190
Type of Change
How Has This Been Tested?
Manual Scenario
Tested on scenario from #1190 -- works as expected.
Checklist (remove irrelevant options):
This is the author self-check list