Correctly handle randomizing of Seed.Recursive modifications#1996
Merged
Vassiliy-Kudryashov merged 1 commit intomainfrom Mar 21, 2023
Merged
Conversation
…re null-this in Java fuzzing
1689416 to
7a8b22f
Compare
Vassiliy-Kudryashov
approved these changes
Mar 21, 2023
Vassiliy-Kudryashov
pushed a commit
that referenced
this pull request
Mar 21, 2023
Correctly handle randomizing of Seed.Recursive modifications and ignore null-this in Java fuzzing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #1990
When fuzzer fails to generate any fields of an object, the object was set to
null. To fix this now null-this values are ignored. Also, there's a non-optimal logic, when fuzzer try to fuzz values of modified fields first and only then choose a subset of those modifications. With this patch fuzzer choose subset of modifications in Seed.Recursive and only then will fuzz them.How to test
Automated tests
All fuzzer tests should pass.
Manual tests
Try an example from the issue. It should generate at least 1 trivial test.
Self-check list