Throw error if name argument is not provided to .file() when uploading a buffer#418
Merged
kadamwhite merged 1 commit intomasterfrom Jan 23, 2019
Conversation
…g a buffer Fixes #344 props @cungminh2710, @mvhirsch
kadamwhite
deleted the
enhancement/add-missing-argument-check-to-file-method-344
branch
kadamwhite
added a commit
that referenced
this pull request
Jan 23, 2019
…g a buffer (#418) Fixes #344 props @cungminh2710, @mvhirsch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No filename can be determined from a buffer object, which causes an
Error: No data suppliedwarning. Adding a specific error check makes this more obvious and will allow consuming developers to quickly identify and resolve the issue.Fixes #344
props @cungminh2710, @mvhirsch