Skip to content

feat: support custom-page-size proposal#8307

Open
HerrCai0907 wants to merge 5 commits intoWebAssembly:mainfrom
wasm-ecosystem:custom-page-size
Open

feat: support custom-page-size proposal#8307
HerrCai0907 wants to merge 5 commits intoWebAssembly:mainfrom
wasm-ecosystem:custom-page-size

Conversation

@HerrCai0907
Copy link
Contributor

@HerrCai0907 HerrCai0907 commented Feb 12, 2026

custom page size proposal

Fixed: #6873
Original PR: #7694

Copy link
Member

@kripken kripken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comments on the first 1/4 or so. Nice work!

@HerrCai0907
Copy link
Contributor Author

test/spec/testsuite/proposals/custom-page-sizes/memory_max.wast will use 4GB of RAM for memory. which may cause the tsan failed. It can work locally (in my 64GiB linux). @kripken @stevenfontanella what do you think for those cases, Do you think we can disable them in CI environment?

;; i32 (pagesize 1)
(assert_unlinkable
  (module
    (import "test" "unknown" (func))
    (memory 0xFFFF_FFFF (pagesize 1)))
  "unknown import")

;; i32 (default pagesize)
(assert_unlinkable
  (module
    (import "test" "unknown" (func))
    (memory 65536 (pagesize 65536)))
  "unknown import")

@HerrCai0907
Copy link
Contributor Author

5c7061e can resolve the RAM usage issue, should I split it to another PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support Custom Page Sizes proposal

3 participants