Require --enable-shared-everything with WaitQueues#8342
Merged
stevenfontanella merged 6 commits intomainfrom Feb 19, 2026
Merged
Require --enable-shared-everything with WaitQueues#8342stevenfontanella merged 6 commits intomainfrom
stevenfontanella merged 6 commits intomainfrom
Conversation
stevenfontanella
force-pushed
the
waitqueue-validation
branch
from
2380848 to
aaee2c2
Compare
tlively
reviewed
Feb 19, 2026
tlively
reviewed
Feb 19, 2026
stevenfontanella
added a commit
that referenced
this pull request
Feb 19, 2026
Followup changes to #8342 * Extract out function for `validateExactReferences` (the existing body of `validateTypes`) and add a note that new validations should probably go in wasm-type.cpp. * Use the anonymous namespace instead of `static` for free functions: https://stackoverflow.com/questions/4977252/why-an-unnamed-namespace-is-a-superior-alternative-to-static
tlively
approved these changes
Feb 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Validate that shared-everything is enabled when a WaitQueue is seen during TypeBuilder::build.
Part of #8315.