Merged
Conversation
Since the project current modularization does not yet allow to split bindings and the rest of the code, moving the `Initializer`s registration to the `:app` module makes it easier to use. - It avoids duplicated registrations (it was both present in `:app` and `:core:network`) - It avoids removing registrations on other modules that would break during instrumented tests `EnsureInitializerMetadata` had to be suppressed because the Lint rule does not actually check where the initializer are registered, and always expects to see it on the same module, which is quite a simplistic assumption. https://googlesamples.github.io/android-custom-lint-rules/checks/EnsureInitializerMetadata.md.html I also remove the hardcoded `androidx.startup` string with the proper string reference `@string/androidx_startup`.
keyboardsurfer
approved these changes
Jun 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since the project current modularization does not yet allow to split bindings and the rest of the code, moving the
Initializers registration to the:appmodule makes it easier to use.:appand:core:network)EnsureInitializerMetadatahad to be suppressed because the Lint rule does not actually check where the initializer are registered, and always expects to see it on the same module, which is quite a simplistic assumption. https://googlesamples.github.io/android-custom-lint-rules/checks/EnsureInitializerMetadata.md.htmlI also remove the hardcoded
androidx.startupstring with the proper string reference@string/androidx_startup.Finally, I removed
core/network/src/main/res/xml/startup_initializers.xmlwhich seems unused and is not documented in the official APIs.startup_initializers.xmlused for? #51Closes #51