[JetSurvey] Use AnimatedContent to slide in and out changes between questions#842
Merged
[JetSurvey] Use AnimatedContent to slide in and out changes between questions#842
Conversation
…e end result screen.
riggaroo
requested review from
IanGClifton and
kul3r4
and removed request for
kul3r4
IanGClifton
reviewed
Jun 17, 2022
Contributor
IanGClifton
left a comment
IanGClifton
left a comment
There was a problem hiding this comment.
This is great! Thank you! I had just one super minor comment
Jetsurvey/app/src/main/java/com/example/compose/jetsurvey/survey/SurveyFragment.kt
Outdated
Show resolved
Hide resolved
simona-anomis
approved these changes
Jun 20, 2022
| JetsurveyTheme { | ||
| viewModel.uiState.observeAsState().value?.let { surveyState -> | ||
| when (surveyState) { | ||
| val state = viewModel.uiState.observeAsState().value ?: return@JetsurveyTheme |
Contributor
There was a problem hiding this comment.
Why the ?: return@JetsurveyTheme change?
Collaborator
Author
There was a problem hiding this comment.
I needed a non-nullable state, and I generally prefer early returns instead of wrapping content in lets 😄 https://betterprogramming.pub/are-early-returns-any-good-eed4b4d03866
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added two usages of AnimatedContent into JetSurvey.
Animate the changes between different question screens, as well as the end result screen.