value of backup.plugin.veeam.password is not decrypted when configured at zone settings

[rajujith]

ISSUE TYPE

• Bug Report

COMPONENT NAME

Veeam
B&R

CLOUDSTACK VERSION

4.19, 4.20-SNAPSHOT 

CONFIGURATION

Veeam B&R provider
Veeam backup and replication

OS / ENVIRONMENT

SUMMARY

If the veeam B&R provider is configured at zone scope the password needs to be set with 'backup.plugin.veeam.password'. Although this value is stored encrypted , while making API calls to veeam this value is not decrypted hence breaking the veeam integration. Error thrown by CloudStack is "Veeam B&R API call unauthorized, please ask your administrator to fix integration issues."
Workaround is to update the data_center_details table with password in plaintext.

This issue is possibly related to the changes in #6812 and #9088

STEPS TO REPRODUCE

1. Deploy Veeam Backup and replication as per the veeam, cloudstack documentation.
2. Configure as per the cloudstack veeam B&R plugin configuration steps.
3. Make sure to configure it on the zone level
4. Import the backup offerings. 

EXPECTED RESULTS

Backup offering should be listed.

ACTUAL RESULTS

backup offerings are not listed. 

[weizhouapache]

thanks @rajujith
we probably need to consider the settings with encrypted value for zone/cluster (similar as #9088 )

[DaanHoogland]

fixed in #10237