Flexibilize public IP selection

[erikbocks]

Description

Currently, when a public IP allocation request is made, the quarantined_ips table is ignored during the selection process. Instead, the system selects an IP without checking its quarantine status, and only validates if the IP is quarantined afterward, throwing an exception if it is.

This causes repeated failures for automatic IP selections, as the same IP will be chosen over and over, until the quarantine period ends.

This PR fixes this behaviour by considering the quarantined_ips table during the selection process, and choosing only an allocatable IP. It also brings a minor improvement to the IP quarantine logic, where IPs that were not removed either in active quarantine, were not set removed when allocated.

Now, when these IPs are allocated, the removed column is updated and the removal reason is set to: IP was removed from quarantine because it was no longer in quarantine. The PR also does a little code refactor, improving its legibility and dropping the usage of deprecated methods.

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• Major
• Minor

How Has This Been Tested?

I made the following tests:

N°	Test case	Result	Expected? (Y/N)
1	Allocate an IP to a VR	IP was allocated successfully	Y
2	Allocate an IP to a System VM	IP was allocated successfully	Y
3	Allocate a specific IP to a VR	IP was allocated successfully	Y
4	Allocate an IP to a VR, but, all the IPs are already allocated	Exception was thrown displaying insufficient address capacity	Y
5	Allocate a specific quarantined IP, but, its quarantine is due.	IP was allocated successfully	Y
6	Allocate a specific quarantined IP, but, it is in active quarantine.	Exception was thrown displaying insufficient address capacity.	Y
7	Allocate a specific quarantined IP, but, the caller is the previous owner	IP was allocated successfully	Y
8	Allocated a specific quarantined IP, but, the previous owner is different than the caller	Exception was thrown displaying insufficient address capacity.	Y

[codecov]

Codecov Report

❌ Patch coverage is 10.52632% with 51 lines in your changes missing coverage. Please review.
✅ Project coverage is 17.89%. Comparing base (7324ef4) to head (d5d4aa9).

Files with missing lines	Patch %	Lines
...n/java/com/cloud/network/IpAddressManagerImpl.java	13.63%	38 Missing ⚠️
...m/cloud/network/dao/PublicIpQuarantineDaoImpl.java	0.00%	13 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##               4.22   #11076      +/-   ##
============================================
+ Coverage     17.62%   17.89%   +0.27%     
- Complexity    15668    16091     +423     
============================================
  Files          5917     5938      +21     
  Lines        531255   532886    +1631     
  Branches      64951    65193     +242     
============================================
+ Hits          93639    95383    +1744     
+ Misses       427077   426824     -253     
- Partials      10539    10679     +140     

Flag	Coverage Δ
uitests	3.67% <ø> (-0.03%)	⬇️
unittests	19.00% <10.52%> (+0.30%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[DaanHoogland]

@blueorangutan package

[blueorangutan]

@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 14153

[DaanHoogland]

@blueorangutan LLtest

[blueorangutan]

@DaanHoogland a [LL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

[DaanHoogland]

@erikbocks , do you still want to move this forwards?

[erikbocks]

Hello, @DaanHoogland

Yes, I wish to move forward with this PR. It is currently waiting for reviews.

[winterhazel]

@erikbocks can this go into 4.20.3?

[erikbocks]

@bernardodemarco I checked the code for the OR operator (#11076 (comment)) use cases and could not find a flow that needed it. Therefore, I removed it.

@winterhazel, sure, I will re-target the PR.

[sureshanaparti]

@blueorangutan package

[blueorangutan]

@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result [SF]: ✖️ el8 ✖️ el9 ✔️ debian ✖️ suse15. SL-JID 16819

[sureshanaparti]

@blueorangutan package

[blueorangutan]

@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 16824