network: ipv6 static routes by shwstppr · Pull Request #5786 · apache/cloudstack

shwstppr · 2021-12-17T10:40:25Z

Description

https://cwiki.apache.org/confluence/display/CLOUDSTACK/IPv6+Support+in+Isolated+Network+and+VPC+with+Static+Routing

Doc PR: apache/cloudstack-documentation#262

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Major
Minor

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

server/src/main/java/com/cloud/configuration/ConfigurationManagerImpl.java

…gerImpl.java Co-authored-by: dahn <daan.hoogland@gmail.com>

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

shwstppr · 2021-12-20T09:57:29Z

@blueorangutan package

blueorangutan · 2021-12-20T09:58:04Z

@shwstppr a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

blueorangutan · 2021-12-20T11:47:49Z

Packaging result: ✖️ el7 ✔️ el8 ✔️ debian ✖️ suse15. SL-JID 1959

shwstppr · 2021-12-21T06:10:03Z

@blueorangutan package

blueorangutan · 2021-12-21T06:11:04Z

@shwstppr a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

blueorangutan · 2021-12-21T07:16:56Z

Packaging result: ✔️ el7 ✔️ el8 ✔️ debian ✔️ suse15. SL-JID 1972

sureshanaparti · 2021-12-21T12:19:49Z

@blueorangutan test

blueorangutan · 2022-04-25T10:30:03Z

@acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

blueorangutan · 2022-04-25T10:34:52Z

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/5786 (SL-JID-1459)

acs-robot · 2022-04-25T11:06:11Z

PR Coverage Report

CLASS	INSTRUCTION MISSED	INSTRUCTION COVERED	BRANCH MISSED	BRANCH COVERED	LINE MISSED	LINE COVERED









Network	554	0	42	0	107	0



















































NetworkOrchestrationService	0	101	0	0	0	10
AlertManager	79	0	0	0	7	0


ConnectedAgentAttache	149	0	20	0	40	0
NetworkOrchestrator	9910	0	1224	0	1945	0
CapacityVO	261	0	0	0	80	0
DataCenterGuestIpv6PrefixVO	45	0	0	0	17	0

DataCenterGuestIpv6PrefixDaoImpl	24	0	0	0	5	0

VlanDaoImpl	1307	0	54	0	218	0

HostDaoImpl	4983	0	180	0	803	0
Ipv6GuestPrefixSubnetNetworkMapVO	64	0	0	0	24	0

Ipv6GuestPrefixSubnetNetworkMapDaoImpl	268	0	2	0	42	0

NetworkDetailsDaoImpl	30	0	4	0	5	0
NetworkVO	396	159	19	1	140	44

VpcOfferingDaoImpl	137	0	0	0	25	0

VpcOfferingDetailsDaoImpl	173	0	10	0	31	0

NetworkOfferingDaoImpl	701	0	24	0	118	0

NicDaoImpl	1392	0	12	0	193	0

SnapshotObject	748	30	64	0	151	11





CloudStackContextLoaderListener	77	0	2	0	21	0
LibvirtComputingResource	8888	1988	1087	147	1983	451


MockNetworkManagerImpl	510	0	24	0	88	0
SimulatorManagerImpl	1394	0	214	0	309	0

MetricsServiceImpl	2130	0	134	0	446	0
ClusterMetricsResponse	523	0	132	0	60	0
VmMetricsResponse	142	0	22	0	25	0
VolumeMetricsResponse	69	0	8	0	10	0
ZoneMetricsResponse	501	0	126	0	56	0

ContrailManagerImpl	2218	0	234	0	497	0

DomainChecker	1206	0	300	0	238	0
AlertManagerImpl	2133	0	183	0	418	0
ApiDBUtils	2374	0	210	0	592	0
ApiResponseHelper	12401	0	1292	0	2837	0
ApiServer	2863	112	346	0	672	14
QueryManagerImpl	14257	0	1248	0	2409	0
NetworkOfferingJoinDaoImpl	286	0	14	0	60	0
VpcOfferingJoinDaoImpl	180	0	8	0	39	0
NetworkOfferingJoinVO	219	0	0	0	79	0
VpcOfferingJoinVO	120	0	0	0	37	0
ConfigurationManagerImpl	18634	0	3092	0	3636	0
HypervisorGuruBase	669	38	52	0	133	5
ExternalFirewallDeviceManagerImpl	1885	0	198	0	381	0
ExternalLoadBalancerDeviceManagerImpl	2591	0	288	0	593	0
IpAddressManagerImpl	4080	0	463	0	813	0
Ipv6AddressManagerImpl	371	0	32	0	70	0
Ipv6ServiceImpl	1666	0	140	0	304	0
NetworkMigrationManagerImpl	1706	0	90	0	355	0
NetworkServiceImpl	13630	0	1898	0	2607	0
FirewallManagerImpl	2600	0	399	0	466	0
ExternalGuestNetworkGuru	844	0	92	0	158	0
GuestNetworkGuru	692	298	114	34	141	64
PublicNetworkGuru	341	0	42	0	77	0
CommandSetupHelper	4086	0	300	0	769	0
NetworkHelperImpl	2092	0	278	0	445	0
VirtualNetworkApplianceManagerImpl	7752	0	792	0	1544	0
NetworkACLManagerImpl	861	0	118	0	182	0
NetworkACLServiceImpl	2701	0	304	0	520	0
VpcManagerImpl	6926	0	770	0	1319	0
StatsCollector	2178	0	124	0	359	0
VolumeApiServiceImpl	10873	0	1502	0	2041	0
UserVmManagerImpl	20798	0	2566	0	3869	0
BasicNetworkVisitor	535	0	28	0	112	0




MockNetworkManagerImpl	510	0	24	0	88	0

acs-robot · 2022-04-25T11:21:47Z

Found UI changes, kicking a new UI QA build
@blueorangutan ui

blueorangutan · 2022-04-25T11:22:03Z

@acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

blueorangutan · 2022-04-25T11:27:31Z

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/5786 (SL-JID-1461)

acs-robot · 2022-04-25T12:09:28Z

PR Coverage Report

CLASS	INSTRUCTION MISSED	INSTRUCTION COVERED	BRANCH MISSED	BRANCH COVERED	LINE MISSED	LINE COVERED








Network	554	0	42	0	107	0








































NetworkOrchestrationService	0	101	0	0	0	10
AlertManager	79	0	0	0	7	0


NetworkOrchestrator	9910	0	1224	0	1945	0
CapacityVO	261	0	0	0	80	0
DataCenterGuestIpv6PrefixVO	45	0	0	0	17	0

DataCenterGuestIpv6PrefixDaoImpl	24	0	0	0	5	0

VlanDaoImpl	1307	0	54	0	218	0
Ipv6GuestPrefixSubnetNetworkMapVO	64	0	0	0	24	0

Ipv6GuestPrefixSubnetNetworkMapDaoImpl	268	0	2	0	42	0

NetworkDetailsDaoImpl	30	0	4	0	5	0
NetworkVO	396	159	19	1	140	44

VpcOfferingDaoImpl	137	0	0	0	25	0

VpcOfferingDetailsDaoImpl	173	0	10	0	31	0

NetworkOfferingDaoImpl	691	0	22	0	114	0

NicDaoImpl	1392	0	12	0	193	0


MockNetworkManagerImpl	510	0	24	0	88	0
SimulatorManagerImpl	1394	0	214	0	309	0
ContrailManagerImpl	2218	0	234	0	497	0
AlertManagerImpl	2133	0	183	0	418	0
ApiResponseHelper	12400	0	1292	0	2837	0
NetworkOfferingJoinDaoImpl	278	0	12	0	57	0
VpcOfferingJoinDaoImpl	172	0	6	0	36	0
NetworkOfferingJoinVO	219	0	0	0	79	0
VpcOfferingJoinVO	120	0	0	0	37	0
ConfigurationManagerImpl	18634	0	3092	0	3636	0
HypervisorGuruBase	669	38	52	0	133	5
ExternalFirewallDeviceManagerImpl	1885	0	198	0	381	0
ExternalLoadBalancerDeviceManagerImpl	2591	0	288	0	593	0
IpAddressManagerImpl	4080	0	463	0	813	0
Ipv6AddressManagerImpl	371	0	32	0	70	0
Ipv6ServiceImpl	1666	0	140	0	304	0
NetworkMigrationManagerImpl	1706	0	90	0	355	0
NetworkServiceImpl	13630	0	1898	0	2607	0
FirewallManagerImpl	2600	0	399	0	466	0
ExternalGuestNetworkGuru	844	0	92	0	158	0
GuestNetworkGuru	692	298	114	34	141	64
PublicNetworkGuru	341	0	42	0	77	0
CommandSetupHelper	4088	0	300	0	771	0
NetworkHelperImpl	2092	0	278	0	445	0
VirtualNetworkApplianceManagerImpl	7752	0	792	0	1544	0
NetworkACLManagerImpl	861	0	118	0	182	0
NetworkACLServiceImpl	2701	0	304	0	520	0
VpcManagerImpl	6926	0	770	0	1319	0
UserVmManagerImpl	20798	0	2566	0	3869	0
BasicNetworkVisitor	535	0	28	0	112	0


MockNetworkManagerImpl	510	0	24	0	88	0

github-actions · 2022-04-25T12:18:21Z

This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.

Signed-off-by: Abhishek Kumar <abhishek.kumar@shapeblue.com>

shwstppr · 2022-04-25T12:44:31Z

@blueorangutan package

acs-robot · 2022-04-25T12:44:41Z

Found UI changes, kicking a new UI QA build
@blueorangutan ui

blueorangutan · 2022-04-25T12:45:02Z

@acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

blueorangutan · 2022-04-25T12:46:34Z

UI build: ✖️
(SL-JID-1464)

blueorangutan · 2022-04-25T12:56:25Z

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/5786 (SL-JID-1465)

shwstppr · 2022-04-25T13:04:37Z

@blueorangutan package

blueorangutan · 2022-04-25T13:05:03Z

@shwstppr a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

acs-robot · 2022-04-25T13:34:01Z

PR Coverage Report

CLASS	INSTRUCTION MISSED	INSTRUCTION COVERED	BRANCH MISSED	BRANCH COVERED	LINE MISSED	LINE COVERED








Network	554	0	42	0	107	0








































NetworkOrchestrationService	0	101	0	0	0	10
AlertManager	79	0	0	0	7	0


NetworkOrchestrator	9910	0	1224	0	1945	0
CapacityVO	261	0	0	0	80	0
DataCenterGuestIpv6PrefixVO	45	0	0	0	17	0

DataCenterGuestIpv6PrefixDaoImpl	24	0	0	0	5	0

VlanDaoImpl	1307	0	54	0	218	0
Ipv6GuestPrefixSubnetNetworkMapVO	64	0	0	0	24	0

Ipv6GuestPrefixSubnetNetworkMapDaoImpl	268	0	2	0	42	0

NetworkDetailsDaoImpl	30	0	4	0	5	0
NetworkVO	396	159	19	1	140	44

VpcOfferingDaoImpl	137	0	0	0	25	0

VpcOfferingDetailsDaoImpl	173	0	10	0	31	0

NetworkOfferingDaoImpl	691	0	22	0	114	0

NicDaoImpl	1392	0	12	0	193	0


MockNetworkManagerImpl	510	0	24	0	88	0
SimulatorManagerImpl	1394	0	214	0	309	0
ContrailManagerImpl	2218	0	234	0	497	0
AlertManagerImpl	2133	0	183	0	418	0
ApiResponseHelper	12400	0	1292	0	2837	0
NetworkOfferingJoinDaoImpl	278	0	12	0	57	0
VpcOfferingJoinDaoImpl	172	0	6	0	36	0
NetworkOfferingJoinVO	219	0	0	0	79	0
VpcOfferingJoinVO	120	0	0	0	37	0
ConfigurationManagerImpl	18652	0	3092	0	3639	0
HypervisorGuruBase	669	38	52	0	133	5
ExternalFirewallDeviceManagerImpl	1885	0	198	0	381	0
ExternalLoadBalancerDeviceManagerImpl	2591	0	288	0	593	0
IpAddressManagerImpl	4084	0	463	0	814	0
Ipv6AddressManagerImpl	371	0	32	0	70	0
Ipv6ServiceImpl	1676	0	140	0	304	0
NetworkMigrationManagerImpl	1706	0	90	0	355	0
NetworkServiceImpl	13648	0	1902	0	2613	0
FirewallManagerImpl	2600	0	399	0	466	0
ExternalGuestNetworkGuru	849	0	92	0	158	0
GuestNetworkGuru	702	298	114	34	142	64
PublicNetworkGuru	341	0	42	0	77	0
CommandSetupHelper	4088	0	300	0	771	0
NetworkHelperImpl	2092	0	278	0	445	0
VirtualNetworkApplianceManagerImpl	7767	0	792	0	1544	0
NetworkACLManagerImpl	861	0	118	0	182	0
NetworkACLServiceImpl	2701	0	304	0	520	0
VpcManagerImpl	6936	0	770	0	1321	0
UserVmManagerImpl	20798	0	2566	0	3869	0
BasicNetworkVisitor	535	0	28	0	112	0


MockNetworkManagerImpl	510	0	24	0	88	0

blueorangutan · 2022-04-25T13:41:29Z

Packaging result: ✔️ el7 ✔️ el8 ✔️ debian ✔️ suse15. SL-JID 3301

weizhouapache

lgtm

* ipv6: support for isolated nw, vpc tiers Feature PR: apache/cloudstack#5786 Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com> * typo fix Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com> * more typo Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com> * changes Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com> * change Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com> * public ip range note Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com> * vpc offering, global setting change Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com> * missing changes from previous commit Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com> * add detail about firewall and acl Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com> * typo Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

shwstppr and others added 15 commits December 16, 2021 11:43

wip

3317085

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

IPv6: configure VR of isolated networks

ef44c34

IPv6: add default IPv6 route in VR of isolated networks

8bc0e03

Reformat server/src/main/java/com/cloud/network/NetworkServiceImpl.java

1cfe54c

IPv6: update network to offering which support IPv6

3874027

IPv6: update vm nic ipv6 address when update network to new offering

cbce2be

IPv6: configure VPC VR to support multiple tiers with IPv6

bcf1d39

IPv6: add RDNSS in radvd.conf

84f8efb

IPv6/UI: support ipv6 protocols in Network ACL

5000bcf

wip

d7543de

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

changes for diagnostics

a44e631

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

more import fromo apache#5594

5100f59

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

IPv6: fix wrong public ipv6 in VPC VR

6b175ee

changes

1aca1fe

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

fix

71f29b4

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

DaanHoogland reviewed Dec 17, 2021

View reviewed changes

server/src/main/java/com/cloud/configuration/ConfigurationManagerImpl.java Outdated Show resolved Hide resolved

shwstppr and others added 5 commits December 17, 2021 16:24

Update server/src/main/java/com/cloud/configuration/ConfigurationMana…

bfa9a06

…gerImpl.java Co-authored-by: dahn <daan.hoogland@gmail.com>

ui: fix add ipv6 prefix labels, message

b329221

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

ui: label fix

d430dd8

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

logging fix

98b2738

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

test fix

178119c

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

apache deleted a comment from blueorangutan Dec 20, 2021

shwstppr force-pushed the ip6-routes branch from 63cd449 to 8bc29b3 Compare April 25, 2022 11:20

github-actions bot added the status:has-conflicts label Apr 25, 2022

shwstppr added 2 commits April 25, 2022 18:09

Merge branch 'main' into ip6-routes

d2d674e

build fix for latest event changes

636ead7

Signed-off-by: Abhishek Kumar <abhishek.kumar@shapeblue.com>

github-actions bot removed the status:has-conflicts label Apr 25, 2022

nvazquez marked this pull request as ready for review April 26, 2022 00:56

nvazquez approved these changes Apr 26, 2022

View reviewed changes

nvazquez merged commit 4a914aa into apache:main Apr 26, 2022

weizhouapache reviewed Apr 26, 2022

View reviewed changes

nvazquez added the type:new-feature label Apr 26, 2022

sureshanaparti mentioned this pull request Jan 29, 2026

Alert type fixes and some code improvements #12546

Open

14 tasks

Comments

Conversation

shwstppr commented Dec 17, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Types of changes

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

Uh oh!

Uh oh!

shwstppr commented Dec 20, 2021

Uh oh!

blueorangutan commented Dec 20, 2021

Uh oh!

blueorangutan commented Dec 20, 2021

Uh oh!

shwstppr commented Dec 21, 2021

Uh oh!

blueorangutan commented Dec 21, 2021

Uh oh!

blueorangutan commented Dec 21, 2021

Uh oh!

sureshanaparti commented Dec 21, 2021

Uh oh!

blueorangutan commented Apr 25, 2022

Uh oh!

blueorangutan commented Apr 25, 2022

Uh oh!

acs-robot commented Apr 25, 2022

PR Coverage Report

Uh oh!

acs-robot commented Apr 25, 2022

Uh oh!

blueorangutan commented Apr 25, 2022

Uh oh!

blueorangutan commented Apr 25, 2022

Uh oh!

acs-robot commented Apr 25, 2022

PR Coverage Report

Uh oh!

github-actions bot commented Apr 25, 2022

Uh oh!

shwstppr commented Apr 25, 2022

Uh oh!

acs-robot commented Apr 25, 2022

Uh oh!

blueorangutan commented Apr 25, 2022

Uh oh!

blueorangutan commented Apr 25, 2022

Uh oh!

blueorangutan commented Apr 25, 2022

Uh oh!

shwstppr commented Apr 25, 2022

Uh oh!

blueorangutan commented Apr 25, 2022

Uh oh!

acs-robot commented Apr 25, 2022

PR Coverage Report

Uh oh!

blueorangutan commented Apr 25, 2022

Uh oh!

weizhouapache left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

shwstppr commented Dec 17, 2021 •

edited

Loading