CLOUDSTACK-8651: [Browser Based Upload Template] Partially uploaded t…#607
CLOUDSTACK-8651: [Browser Based Upload Template] Partially uploaded t…#607koushik-das wants to merge 3 commits intoapache:masterfrom
Conversation
…emplates doesn't get cleaned up after the SSVM handling it is destroyed Fixed template sync code to include templates in 'NotUploaded' and 'UploadInProgress' states along with 'Active'.
|
Test browser based incomplete template upload, followed by SSVM destroy. Template should go to UploadAbandoned state and get cleaned up. ... === TestName: test_browser_upload_template_incomplete | Status : SUCCESS === Ran 1 test in 111.128s OK |
There was a problem hiding this comment.
Can you add an assert for UploadAbandoned state of the template? Right now we are just asserting that the template is not active
There was a problem hiding this comment.
It will not be possible to test for UploadAbandoned/Error as storage GC thread will run and move the templates to Inactive state. It is difficult to control at what point the storage GC thread runs and the assert needs happen before that.
Thats why I am only asserting that the template is cleaned up at the end of the test. The destroy_ssvm() ensures that storage GC runs at least once after the template sync is done.
|
looks good 👍 |
|
Need one more LGTM. Anyone? |
|
still running simulator, code lgtm |
|
I think this one can be merged after simulator is done, right? |
|
@DaanHoogland Are you running some private simulator test? If so is it done? |
|
Daan Hoogland on dev@cloudstack.apache.org replies: \sbpltc2kag3qr\dhoogland:~/cloudstack/cloudstack/test/integration ==== Marvin Init Started ==== === Marvin Parse Config Successful === === Marvin Setting TestData Successful=== ==== Log Folder Path: /tmp//MarvinLogs//Jul_27_2015_13_59_07_QHRK18. === Marvin Init Logging Successful=== ==== Marvin Init Successful ==== ===final results are now copied to: /tmp//MarvinLogs/test_suite_IGW70H=== ERROR: test suite for <class 'integration.component.test_browse_templates.TestBrowseUploadVolume'>Traceback (most recent call last): |
|
never mind that last bot-comment, i found a working config its running. will get results in a minute. if impatient and a hero, go with your own result ;) |
|
Hi , I have fixed the test data file to move the browser volume/template specific data from "configurableData” section. But automation script is still pointing the data to "configurableData” section : Ex: 84 cls.uploadurl=cls.testdata["configurableData"]["browser_upload_template"][cls.uploadtemplateformat]["url"] This needs to be fixed. I am yet to work on it. Thanks, |
|
I would like to see the test run pass but don't think it is fair that this should be blocked by an older error in test code. @koushik-das please comment on how you executed the test and you have my lgtm |
|
@DaanHoogland I will create a separate test file with new the test case for now. Once the issues in test_browse_templates.py are fixed, will merge it back later on. |
|
Moved the test to a new file test_browse_templates2.py. This is the command to run it nosetests-2.7 --with-marvin --marvin-config=setup/dev/advanced.cfg --with-xunit --xunit-file=test_output.xml test/integration/component/test_browse_templates2.py -a required_hardware=false --zone=Sandbox-simulator --hypervisor=simulator |
|
cloudstack-pull-rats #140 SUCCESS |
|
cloudstack-pull-requests #838 UNSTABLE |
|
cloudstack-pull-analysis #73 SUCCESS |
|
thanks @koushik-das , as the test issue is being addressed now please don't let it block this PR for the record, the extra test runs as the innocent bystander might expect. |
CloudStack PR: #4175 Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
6 participants
…emplates doesn't get cleaned up after the SSVM handling it is destroyed
Fixed template sync code to include templates in 'NotUploaded' and 'UploadInProgress' states along with 'Active'.