Fix allocation of VMs with multiple clusters

[BryanMLima]

Description

This PR fixes a scenario where if the first cluster verified by ACS does not have any compatible hosts, an exception is thrown, ignoring the verification of possible compatible hosts in other clusters.

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)
• build/CI

Feature/Enhancement Scale or Bug Severity

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

Screenshots (if appropriate):

How Has This Been Tested?

• Cluster 1: Host A
• Cluster 2: Host B

Using the environment above, I added the flexible host tag false to Host A, and tried to deploy a VM; which would always result on an incompatible host for Cluster 1. Prior to this patch, the CloudRuntimeException is thrown with the message No suitable host found for vm [...]. and Host B is not verified.

After applying this patch, the message No suitable host found for VM [%s] in %s. is still logged, however, Host B is verified for compatibility and the VM is deployed as expected.

How did you try to break this feature and the system with this change?

[weizhouapache]

@BryanMLima
target to main or 4.18/4.19 ?

[BryanMLima]

@BryanMLima target to main or 4.18/4.19 ?

Thanks, I rebased to 4.19 as the problem arose from PR #7489.

[BryanMLima]

@blueorangutan package

[blueorangutan]

@BryanMLima a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c795547) 20.99% compared to head (710c848) 4.38%.
Report is 16 commits behind head on 4.19.

❗ Current head 710c848 differs from pull request most recent head 6676a4b. Consider uploading reports for the commit 6676a4b to get more accurate results

Additional details and impacted files

@@             Coverage Diff              @@
##               4.19   #8611       +/-   ##
============================================
- Coverage     20.99%   4.38%   -16.62%     
============================================
  Files          4849     361     -4488     
  Lines        324441   28700   -295741     
  Branches      45573    5004    -40569     
============================================
- Hits          68121    1258    -66863     
+ Misses       246563   27303   -219260     
+ Partials       9757     139     -9618     

Flag	Coverage Δ
simulator-marvin-tests	?
uitests	4.38% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[blueorangutan]

@DaanHoogland a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

[DaanHoogland]

clgtm

[yadvr]

LGTM - but this need some (manual) testing

[BryanMLima]

@blueorangutan package

[blueorangutan]

@BryanMLima a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 8820

[DaanHoogland]

@blueorangutan test

[blueorangutan]

@DaanHoogland a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

[blueorangutan]

[SF] Trillian test result (tid-9375)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 47115 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8611-t9375-kvm-centos7.zip
Smoke tests completed. 128 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_02_trigger_shutdown	Failure	336.69	test_safe_shutdown.py

[JoaoJandre]

CLGTM, didn't test it

[BryanMLima]

@blueorangutan package

[blueorangutan]

@BryanMLima a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9676

[borisstoyanov]

LGTM, manually checked the changes.