linstor: disconnect-disk also search for resource name in Linstor

[rp-]

Description

disconnectPhysicalDisk(String, KVMStoragePool) seems to calls the plugin with the resource name instead of the device path, so we also have to search for resource names, while cleaning up.

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)
• build/CI

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• Major
• Minor

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

Screenshots (if appropriate):

How Has This Been Tested?

6 Node CloudStack cluster, non hyperconverged.

How did you try to break this feature and the system with this change?

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 12.24%. Comparing base (5c9d79e) to head (8baaed0).

Files	Patch %	Lines
.../hypervisor/kvm/storage/LinstorStorageAdaptor.java	0.00%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##               4.18    #9035    +/-   ##
==========================================
  Coverage     12.24%   12.24%            
- Complexity     9291     9292     +1     
==========================================
  Files          4698     4698            
  Lines        414259   414259            
  Branches      52267    51817   -450     
==========================================
+ Hits          50707    50716     +9     
+ Misses       357251   357241    -10     
- Partials       6301     6302     +1     

Flag	Coverage Δ
unittests	12.24% <0.00%> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[DaanHoogland]

@rp- , isn't this obfuscating a bug where the path should have been stored instead of the name?

[rp-]

@rp- , isn't this obfuscating a bug where the path should have been stored instead of the name?

Good point, but I store the disk uuid as path and reference for Linstor and it only gets translated to the real device path in the getPhysicalDisk() and createPhysicalDisk() calls in the adaptor.

So yes, the name volumePath might be misleading here, because in Linstor case it is actually part of the resource name.

[sureshanaparti]

CLGTM

[sureshanaparti]

@blueorangutan package

[blueorangutan]

@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9527

[DaanHoogland]

@blueorangutan test

[blueorangutan]

@DaanHoogland a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

[blueorangutan]

[SF] Trillian test result (tid-10161)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 45197 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9035-t10161-kvm-centos7.zip
Smoke tests completed. 109 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_08_migrate_vm	Error	0.06	test_vm_life_cycle.py