get expunged VM data for job result by DaanHoogland · Pull Request #9949 · apache/cloudstack

DaanHoogland · 2024-11-20T09:48:55Z

Description

This PR...

Fixes: #9946

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)
build/CI
test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Major
Minor

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

vishesh92

clgtm. Haven't tested yet.

vishesh92 · 2024-11-20T13:00:41Z

@blueorangutan package

blueorangutan · 2024-11-20T13:02:04Z

@vishesh92 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

weizhouapache

code lgtm

The response does not contain removed nics, volumes, etc. But I think it is ok

blueorangutan · 2024-11-20T13:13:04Z

Packaging result [SF]: ✖️ el8 ✖️ el9 ✖️ debian ✖️ suse15. SL-JID 11584

codecov · 2024-11-20T14:00:54Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 15.10%. Comparing base (a2690e9) to head (a37dc98).
Report is 2 commits behind head on 4.19.

Additional details and impacted files

@@             Coverage Diff              @@
##               4.19    #9949      +/-   ##
============================================
- Coverage     15.10%   15.10%   -0.01%     
+ Complexity    11225    11220       -5     
============================================
  Files          5404     5404              
  Lines        473502   473502              
  Branches      57733    57733              
============================================
- Hits          71543    71527      -16     
- Misses       393961   393981      +20     
+ Partials       7998     7994       -4

Flag	Coverage Δ
uitests	`4.30% <ø> (ø)`
unittests	`15.82% <100.00%> (-0.01%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

DaanHoogland · 2024-11-20T14:20:46Z

@blueorangutan package

blueorangutan · 2024-11-20T14:22:03Z

@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2024-11-20T15:27:48Z

Packaging result [SF]: ✖️ el8 ✖️ el9 ✔️ debian ✖️ suse15. SL-JID 11587

DaanHoogland · 2024-11-20T15:37:11Z

@blueorangutan test

blueorangutan · 2024-11-20T15:38:04Z

@DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

blueorangutan · 2024-11-21T05:13:52Z

[SF] Trillian test result (tid-11787)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 46612 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9949-t11787-kvm-ol8.zip
Smoke tests completed. 132 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_01_secure_vm_migration	`Error`	417.73	test_vm_life_cycle.py
test_02_unsecure_vm_migration	`Error`	472.87	test_vm_life_cycle.py
test_03_secured_to_nonsecured_vm_migration	`Error`	387.36	test_vm_life_cycle.py

DaanHoogland · 2024-11-25T09:04:41Z

@blueorangutan test

blueorangutan · 2024-11-25T09:06:04Z

@DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

blueorangutan · 2024-11-25T23:01:40Z

[SF] Trillian test result (tid-11795)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 47739 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9949-t11795-kvm-ol8.zip
Smoke tests completed. 133 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File

* 4.20: UI: Tooltip on the host information card to display the CPU speed in MHz and the memory value in MB (to 3 decimal places) (#9971) UI: Allow accounts of the `User` type to add other accounts or users to projects through UI (#9927) enable to create VPC portfowarding rules with source cidr (#7081) Add new column `last_id` to the table volumes (#9759) Allow VMWare import via another host (#9787) Linstor: add support for ISO block devices and direct download (#9792) get expunged VM data for job result (#9949) fix section divider display on auth page (#9966)

* 4.20: UI: Tooltip on the host information card to display the CPU speed in MHz and the memory value in MB (to 3 decimal places) (apache#9971) UI: Allow accounts of the `User` type to add other accounts or users to projects through UI (apache#9927) enable to create VPC portfowarding rules with source cidr (apache#7081) Add new column `last_id` to the table volumes (apache#9759) Allow VMWare import via another host (apache#9787) Linstor: add support for ISO block devices and direct download (apache#9792) get expunged VM data for job result (apache#9949) fix section divider display on auth page (apache#9966)

get expunged VM data for job result

6f85033

DaanHoogland mentioned this pull request Nov 20, 2024

destroyVirtualMachine API call with expunge set to true returns null in the response #9946

Closed

vishesh92 approved these changes Nov 20, 2024

View reviewed changes

vishesh92 changed the base branch from main to 4.19 November 20, 2024 13:00

weizhouapache approved these changes Nov 20, 2024

View reviewed changes

vishesh92 closed this Nov 20, 2024

vishesh92 reopened this Nov 20, 2024

only find including removed after destroy

a37dc98

DaanHoogland marked this pull request as ready for review November 25, 2024 09:03

DaanHoogland added the status:ready-for-merge label Nov 27, 2024

DaanHoogland added this to the 4.19.2 milestone Nov 27, 2024

sureshanaparti approved these changes Nov 27, 2024

View reviewed changes

DaanHoogland merged commit a73841a into apache:4.19 Nov 28, 2024

DaanHoogland deleted the ghi9946-asyncJobResult branch November 28, 2024 16:46

DaanHoogland removed the status:ready-for-merge label Nov 28, 2024

bernardodemarco mentioned this pull request Dec 2, 2024

4.20.merge #10013

Closed

14 tasks

dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Dec 12, 2024

get expunged VM data for job result (apache#9949)

1420c76

Conversation

DaanHoogland commented Nov 20, 2024

Description

Types of changes

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

Uh oh!

vishesh92 left a comment

Choose a reason for hiding this comment

Uh oh!

vishesh92 commented Nov 20, 2024

Uh oh!

blueorangutan commented Nov 20, 2024

Uh oh!

weizhouapache left a comment

Choose a reason for hiding this comment

Uh oh!

blueorangutan commented Nov 20, 2024

Uh oh!

codecov bot commented Nov 20, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

DaanHoogland commented Nov 20, 2024

Uh oh!

blueorangutan commented Nov 20, 2024

Uh oh!

blueorangutan commented Nov 20, 2024

Uh oh!

DaanHoogland commented Nov 20, 2024

Uh oh!

blueorangutan commented Nov 20, 2024

Uh oh!

blueorangutan commented Nov 21, 2024

Uh oh!

DaanHoogland commented Nov 25, 2024

Uh oh!

blueorangutan commented Nov 25, 2024

Uh oh!

blueorangutan commented Nov 25, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

codecov bot commented Nov 20, 2024 •

edited

Loading