Support parent dynamic filters for more join types#20192
Draft
jackkleeman wants to merge 1 commit intoapache:mainfrom
Draft
Support parent dynamic filters for more join types#20192jackkleeman wants to merge 1 commit intoapache:mainfrom
jackkleeman wants to merge 1 commit intoapache:mainfrom
Conversation
github-actions
bot
added
sqllogictest
jackkleeman
force-pushed
the
dynamic-filter-join-pushdown
branch
from
81dbc8e to
02a9c18
Compare
jackkleeman
force-pushed
the
dynamic-filter-join-pushdown
branch
2 times, most recently
from
5e8a33f to
4c4982e
Compare
jackkleeman
force-pushed
the
dynamic-filter-join-pushdown
branch
from
4c4982e to
859dbb7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Solves the simplest possible subset of #16973
Rationale for this change
Parent dynamic filters can be assessed for pushdown in much the same way as parent static filters. The essence of it is that you can push a filter into the preserved side if the filter only refers to preserved side columns. This PR makes no attempt to cover other cases (eg non preserved side filters or the self filters that hashjoin creates)
What changes are included in this PR?
ChildFilterDescription::all_unsupportedandChildFilterDescription::from_child_with_allowed_columnsFilterColumnCheckerneeds to look at indices, not just column names, as the same name can be on both sides of a joinAre these changes tested?
Yes
Are there any user-facing changes?
No